Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Extensions For Alias #264

Merged
merged 3 commits into from Jan 27, 2016
Merged

Video Extensions For Alias #264

merged 3 commits into from Jan 27, 2016

Conversation

goehle
Copy link
Member

@goehle goehle commented Dec 23, 2015

PGalias will handle video files without any chage with a small change to add video extensions. This is useful if you want to serve video in pg directly with the

@goehle goehle mentioned this pull request Jan 3, 2016
@goehle
Copy link
Member Author

goehle commented Jan 3, 2016

Would it be worth adding a video command like the image command? Right now you have to set things up manually with something like

$videoaddress = alias('VideoFile.mp4');

TEXT(MODES(TeX=>'The video must be viewed online.', HTML=><<"EOH"));
<video width="400"  controls>
  <source src="$videoaddress" type="video/mp4">
</video>
EOH

@mgage
Copy link
Sponsor Member

mgage commented Jan 4, 2016

go ahead and add a video embedding command (like image). You can put it in PGbasicmacros.pl since it is short enough.

@goehle
Copy link
Member Author

goehle commented Jan 11, 2016

I added a video tag. You can test this by

  1. Put a video file in a location where alias will find it (e.g. in the same folder as your .pg file).
  2. Use the video command to print the video. Options are height and width. E.G:
\{video('filename.ogg',height=>300,width=>350)\}

Check that the options work and that it produces good out put in both html and latex.

@mgage
Copy link
Sponsor Member

mgage commented Jan 27, 2016

I checked this with the file moodle_gradebook.mp4. Both the hand embedding using alias and the video() macro made the proper links. They also recorded things correctly in a PGresource object.

This is ready to go.

mgage added a commit that referenced this pull request Jan 27, 2016
Video Extensions For Alias
@mgage mgage merged commit 08994f4 into openwebwork:develop Jan 27, 2016
@goehle goehle deleted the aliasvid branch July 15, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants