Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CheckboxList part answers of a RadioMultiAnswer. #930

Merged

Conversation

drgrice1
Copy link
Sponsor Member

If a CheckboxList is one of the answers in a RadioMultiAnswer part, then the checkboxes are not enabled/disabled correctly as the radio buttons are checked. This fixes that.

This was not implemented previously because there was no MathObject checkbox answer. Now there is so this is needed.

An example problem is attached. In that problem with the develop branch if you select various radio buttons in the problem you will see that only the first checkbox is enabled or disabled when the radio button for its part is selected or unselected. With this pull request all checkboxes are enabled and disabled appropriately.
rma-with-checkbox-sub.pg.txt

Copy link
Sponsor Member

@drdrew42 drdrew42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@drgrice1 drgrice1 force-pushed the radio-multi-answer-checkbox-sub branch from ca9f1cc to d1dfc05 Compare October 2, 2023 21:34
If a CheckboxList is one of the answers in a RadioMultiAnswer part, then
the checkboxes are not enabled/disabled correctly as the radio buttons
are checked.  This fixes that.

This was not implemented previously because there was no MathObject
checkbox answer.  Now there is so this is needed.
@drgrice1 drgrice1 force-pushed the radio-multi-answer-checkbox-sub branch from d1dfc05 to 4923e20 Compare October 6, 2023 10:36
@pstaabp pstaabp merged commit 204adee into openwebwork:develop Oct 9, 2023
2 checks passed
@drgrice1 drgrice1 deleted the radio-multi-answer-checkbox-sub branch October 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants