Rework the Course Settings #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ProblemSets and UserSets.
…sts to work (only in ET).
…set_params to set_dates.
…store and set to the database. TEST: adding tests to ensure that only valid models are added to the store and set to the database.
FIX: cleanup and using true/false in tests.
WIP: work on course_settings WIP: continued work on the course settings WIP: continued work on course_settings. TEST: mojolicious route testing for settings. WIP: continued work on course settings
|
Closing this since #108 is identical and has been rebased onto main. |
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the way course settings are handled on the back end. Specifically
There are new routes for fetching/updating/deleting global and course settings.
Because of this, the settings modules on the front end side changes to reflect the back end changes. Including
db_course_settingsare stored separately (similar to other data in the stores) and then merged.There are a lot more tests now including
t/db/002_course_settings.tis rewritten to reflect the new course settings back end database model.t/mojolicious/015_course_settings.tis a new to test all of the routestests/unit-tests/settings.tstests the new model and handling of exceptions.tests/stores/settings.tstests the settings store.The UI is mostly unchanged except for using some new store getters and now has the ability to save course settings.
To test
t/db/build_db.plprove -r tnpm run testnpm run test-storeNote: I think GitHub is not accurately managing the changes. A git diff between this and main is 20 files, mostly related to settings.