Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update node and electron #36

Merged
merged 6 commits into from
Jul 11, 2020
Merged

fix(deps): update node and electron #36

merged 6 commits into from
Jul 11, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Jul 11, 2020 •
edited

Goals: improve security, fix #22.

Also fixes crash when quitting the app on macOS.

Changes:

@adrienjoly adrienjoly added the dependencies Pull requests that update a dependency file label Jul 11, 2020
@adrienjoly adrienjoly self-assigned this Jul 11, 2020
@adrienjoly adrienjoly marked this pull request as ready for review July 11, 2020 11:57
@adrienjoly
- move most dependencies to devDependencies (see electron/packager#827)
cdf475e 
- only build x64 binaries (see https://www.electronjs.org/blog/linux-32bit-support)
- only build for darwin/macos, windows and linux
@adrienjoly adrienjoly merged commit 0d7308d into master Jul 11, 2020
@adrienjoly adrienjoly deleted the fix/deps-update-node-and-electron branch July 11, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce size of distributed binary
1 participant
@adrienjoly