fix(clean-up): Remove swfobject and other unused scripts and pages (#343

)

`swfobject` was used by our player, for when audio streams were still still delivered using Adobe/Macromedia Flash. Fortunately for us all, we got rid of this ancient technology! 🧹

.codeclimate.yml

@@ -1,33 +1,30 @@
-engines: 
+engines:
   duplication:
     enabled: true
     config:
       languages:
-      - javascript
+        - javascript
   eslint:
     enabled: true
-    channel: "eslint-2"
+    channel: 'eslint-2'
     config:
       config: ./.eslintrc
 
 ratings:
   paths:
-    - "./app/**.js"
+    - './app/**.js'
 
 exclude_patterns:
-  - "./config/"
-  - "./public/js/jquery*.js"
-  - "./public/js/swfobject.js"
-  - "./public/js/soundmanager2.js"
-  - "./public/js/*-all.js"
-  - "./public/js/*-min.js"
-  - "./public/js/*.min.js"
-  - "features/"
-  - "**/node_modules/"
-  - "**/unused/"
-  - "**/unused/"
-  - "**/spec/"
-  - "**/test/"
-  - "**/tests/"
-  - "**/vendor/"
-  - "**/*.d.ts"
+  - './config/'
+  - './public/js/jquery*.js'
+  - './public/js/soundmanager2.js'
+  - './public/js/*-all.js'
+  - './public/js/*-min.js'
+  - './public/js/*.min.js'
+  - 'features/'
+  - '**/node_modules/'
+  - '**/spec/'
+  - '**/test/'
+  - '**/tests/'
+  - '**/vendor/'
+  - '**/*.d.ts'

app/templates/feed.js

@@ -208,7 +208,6 @@ exports.renderFeedEmbed = function (feedHtml, options) {
       ? 'feedEmbedV2.css'
       : 'feedEmbed.css'
   );
-  options.js.push('swfobject.js');
   options.js.push('playem-min.js');
   options.js.push('playem-youtube-iframe-patch.js');
   options.js.push('whydPlayer.js');

app/templates/mainTemplate.js

@@ -360,7 +360,6 @@ exports.renderWhydPage = function (params) {
         'ui.js',
         'whyd.js', // topicBrowser.js
         //	"ContentEmbed.js", // definitely replaced by playemjs, at last! :-)
-        'swfobject.js',
       ]
   )
     .concat(['playem-' + playemFile + '.js'])
@@ -397,7 +396,6 @@ exports.renderWhydPage = function (params) {
     '<div class="topWarning">Warning: your web browser is not supported by Openwhyd. Please upgrade to a modern browser.</div>',
     '<![endif]-->',
     //	'<a id="feedbackLink" href="mailto:contact@openwhyd.org?subject=[proto-support]&body=Please%20enter%20your%20feedback%20here">Send feedback</a>',
-    //	'<a id="feedbackLink" href="#" onclick="UserVoice.Popin.show(uservoiceOptions); return false;">&nbsp;</a>',
     exports.renderHeader(user, params.whydHeaderContent, params),
     '<div id="contentPane">',
     '  <div id="mainPanel">',
@@ -408,7 +406,6 @@ exports.renderWhydPage = function (params) {
     params.footer || exports.footer,
     exports.olark,
     params.endOfBody || '',
-    //	'<script src="'+render.urlPrefix+'/js/uservoice.js"></script>'
   ];
 
   return this.renderWhydFrame(out.join('\n'), params);