Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(email-notif): ability to unsubscribe from notification emails (#186) #187

Merged
merged 7 commits into from
Jan 27, 2019

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Jan 20, 2019

Closes #186.

  • fixes reduction of frequency for email notifications
  • fixes message after unsubscribing from notification emails
  • refactors unsubscribe logic, for better clarity
  • adds tests for email notifications
  • adds browser.clickOnVisibleSelector() wdio command
  • adds webUI.signup() for tests

@adrienjoly adrienjoly changed the title add tests for email notifications fix(email-notif): ability to unsubscribe from notification emails (#186) Jan 20, 2019
@adrienjoly adrienjoly self-assigned this Jan 20, 2019
@adrienjoly
Copy link
Member Author

$ npm run docker-seed && wdio wdio.conf.js --spec test/specs/email-notifications.tests.js

[chrome #0-0] reduce frequency of email notifications
[chrome #0-0]   ✓ create a test user
[chrome #0-0]   ✓ user has instant email notifications"
[chrome #0-0]   ✓ user activates daily email notifications
[chrome #0-0]   ✓ user now has daily email notifications"
[chrome #0-0]   ✓ user reduces frequency of notifications from email
[chrome #0-0]   1) user sees switch to weekly notifications emails
[chrome #0-0]   2) user now has weekly email notifications"
[chrome #0-0]   ✓ user logs out
[chrome #0-0]
[chrome #0-0] unsubscribe from email notifications
[chrome #0-0]   ✓ create a test user
[chrome #0-0]   ✓ user has instant email notifications"
[chrome #0-0]   ✓ user unsubscribes from email
[chrome #0-0]   3) user sees unsubscription message
[chrome #0-0]   ✓ user was effectively unsubscribed from email notifications"
[chrome #0-0]   ✓ user logs out
[chrome #0-0]
[chrome #0-0]
[chrome #0-0] 11 passing (38s)
[chrome #0-0] 3 failing

1) reduce frequency of email notifications user sees switch to weekly notifications emails:
response should contain "weekly"

2) reduce frequency of email notifications user now has weekly email notifications":
-1 == 7

3) unsubscribe from email notifications user sees unsubscription message:
response should contain "never"

@adrienjoly adrienjoly merged commit 12af968 into master Jan 27, 2019
@adrienjoly adrienjoly deleted the fix/186-email-notif-unsub branch January 27, 2019 12:55
adrienjoly pushed a commit that referenced this pull request Jan 27, 2019
## [1.4.8](v1.4.7...v1.4.8) (2019-01-27)

### Bug Fixes

* **email-notif:** ability to unsubscribe from notification emails ([#186](#186)) ([#187](#187)) ([12af968](12af968))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsubscribe link reduces frenquency of mailings instead of unsubscribing
1 participant