fix: append PORT to URL_PREFIX only if WHYD_URL_PREFIX is not provided #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienjoly
pushed a commit
that referenced
this pull request
Jun 9, 2019
## [1.7.1](v1.7.0...v1.7.1) (2019-06-09) ### Bug Fixes * append PORT to URL_PREFIX only if WHYD_URL_PREFIX is not provided ([#198](#198)) ([e63ee79](e63ee79)), closes [/github.com/openwhyd/openwhyd/commit/cc3af51b2d24e98d24e10583add56ab83bd535de#commitcomment-33865126](https://github.com//github.com/openwhyd/openwhyd/commit/cc3af51b2d24e98d24e10583add56ab83bd535de/issues/commitcomment-33865126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / solve?
Bug: a user reported that the "unsubscribe" link from his digest/notification email did not work:
Source: cc3af51#commitcomment-33865126
Overview of changes
This PR fixes the way the URL_PREFIX is computed when running in production. It should fix the URL of unsubscribe links.