refact(api): migrate from my/session to express-session and connect-mongo #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienjoly
changed the title
adrienjoly
pushed a commit
that referenced
this pull request
Jun 29, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #122 and #55.
What does this PR do / solve?
Openwhyd was developed on top of a custom / home-made web framework called "my-http". In order to standardise it and reduce tech debt, we intend to migrate to Express.js.
This PR is a first step towards that goal: it replaces the custom "my-session" middleware by a more standard combination: connect-mongo and express-session.
Overview of changes
See list of commits for more details.