Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(back-end): migrate from "my/http" to Express.js - part 3 #204

Merged
merged 27 commits into from
Jul 3, 2019
Merged

feat(back-end): migrate from "my/http" to Express.js - part 3 #204

merged 27 commits into from
Jul 3, 2019

Conversation

adrienjoly
Copy link
Member

Contributes to #122.

What does this PR do / solve?

Openwhyd has been running on a legacy / home-made web framework, which can be a turn-off for potential contributors who are used to Express.js

Overview of changes

As a third step of the migration explained in #122, this PR consists of removing the legacy "glue" code from my/http from the Express.js wrapper.

How to test this PR?

Run automated test suites.

@adrienjoly adrienjoly self-assigned this Jul 3, 2019
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Jul 3, 2019
@adrienjoly adrienjoly mentioned this pull request Jul 3, 2019
Open
5 tasks
@adrienjoly adrienjoly force-pushed the refact/migrate-to-express-3 branch from 7627262 to d6c8713 Compare July 3, 2019 13:52
@adrienjoly
plug sessionMiddleware directly to Express
99a6bc4
@adrienjoly
plug sessionMiddleware directly to Express
34efad9
@adrienjoly
also plug bodyParser (almost) directly to Express
8578275
@adrienjoly
simplify injection of legacyRender()
0dfbccb
@adrienjoly
remove custom list of mime types
a0a1a32
@adrienjoly
fix error reporting
15623c5
@adrienjoly
fix the stop() method
4c784c0
@adrienjoly
remove legacy querystring parsing
1bdf91c
@adrienjoly
remove old/unused fields
aa54b29
@adrienjoly
define and pass bodyParser() directly as an Express middleware
355717b
@adrienjoly
generate Express endpoint handlers from routes defined in app.route
0521ac1
@adrienjoly
refactor Application class
1986288
@adrienjoly
add error handling + refactor class for concision
9057903
@adrienjoly
inject legacyRender() directly into http.ServerResponse.prototype
3fee135
@adrienjoly
minor cleaning and refacto
a45533a
@adrienjoly
refactor / simplify settings & options passed to Application constructor
8dd0466
@adrienjoly adrienjoly merged commit 00e4db2 into master Jul 3, 2019
Development automation moved this from 📥 Inbox / ideas to ✔️ Done / pending QA Jul 3, 2019
@adrienjoly adrienjoly deleted the refact/migrate-to-express-3 branch July 3, 2019 20:02
adrienjoly pushed a commit that referenced this pull request Jul 3, 2019
@semantic-release-bot
chore(release): 1.11.0 [skip ci]
dc2775f 
# [1.11.0](v1.10.0...v1.11.0) (2019-07-03)

### Features

* **back-end:** migrate from "my/http" to Express.js - part 3 ([#204](#204)) ([00e4db2](00e4db2)), closes [#122](#122) [#122](#122)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
enhancement
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adrienjoly