feat(maintenance): restart script generates nginx config from template #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienjoly
changed the title
adrienjoly
pushed a commit
that referenced
this pull request
Nov 23, 2019
# [1.17.0](v1.16.0...v1.17.0) (2019-11-23) ### Features * **maintenance:** restart script generates nginx config from template ([#248](#248)) ([efa8296](efa8296))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / solve?
The configuration of our
nginxHTTP proxy contains redundant definitions in/etc/nginx/sites-available, in order to allow no-downtime deployments. (which rely on switching from a port to another)Redundancy makes it harder and riskier to update the
nginxconfiguration.Overview of changes
This PR makes the
restart.shscript re-generate these twonginxconfiguration from a template file. => The template becomes the source of truth, and it's versionned in this repo.How to test this PR?
Test in production :-p