Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Create dummy posts from Cypress tests instead of from db init #304

Merged
merged 3 commits into from
Mar 22, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Mar 22, 2020

Contributes to #199.

What does this PR do / solve?

We recently added 21 hard-coded fake posts in config/initdb_testing.js, so that the pagination test could run.

These 21 posts are just required by that tests, so they should be added from that test only.

Overview of changes

Add a postDummyTracks() command that generates and inserts a given number of posts for the currently logged-in user. => Call it from pagination tests.

@adrienjoly adrienjoly self-assigned this Mar 22, 2020
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Mar 22, 2020
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to ⚙ In progress in Development Mar 22, 2020
* master:
  fix(tests): Reset database between each Cypress tests (#302)

# Conflicts:
#	cypress/support/commands.js
#	cypress/support/index.d.ts
@adrienjoly adrienjoly marked this pull request as ready for review March 22, 2020 17:01
@adrienjoly adrienjoly merged commit e37a0d0 into master Mar 22, 2020
Development automation moved this from ⚙ In progress to ✔️ Done / pending QA Mar 22, 2020
@adrienjoly adrienjoly deleted the fix/199-create-posts-from-cypress branch March 22, 2020 17:05
adrienjoly added a commit that referenced this pull request Mar 22, 2020
…river-to-cypress

* master:
  fix(tests): create dummy posts from cypress tests instead of from initdb_testing (#304)
  chore(release): 1.30.3 [skip ci]
  fix(tests): Reset database between each Cypress tests (#302)

# Conflicts:
#	cypress/support/index.js
adrienjoly pushed a commit that referenced this pull request Mar 22, 2020
## [1.30.4](v1.30.3...v1.30.4) (2020-03-22)

### Bug Fixes

* **tests:** create dummy posts from cypress tests instead of from initdb_testing ([#304](#304)) ([e37a0d0](e37a0d0)), closes [#199](#199)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Mar 22, 2020
adrienjoly added a commit that referenced this pull request Mar 23, 2020
* master: (64 commits)
  chore(release): 1.30.6 [skip ci]
  fix(ui): Resizing the page should not scroll to the top (#303)
  chore(release): 1.30.5 [skip ci]
  fix(tests): Migrate acceptance tests from Webdriver to Cypress (#301)
  chore(release): 1.30.4 [skip ci]
  fix(tests): create dummy posts from cypress tests instead of from initdb_testing (#304)
  chore(release): 1.30.3 [skip ci]
  fix(tests): Reset database between each Cypress tests (#302)
  chore(release): 1.30.2 [skip ci]
  fix(ui): Display correct track error message when using electron app (#294)
  chore(release): 1.30.1 [skip ci]
  fix(error): 404 redirect when clicking load more on account stream (#296)
  test(#295): add non-regression test for pagination (#299)
  chore(release): 1.30.0 [skip ci]
  feat(ci): separate ci tasks for each type of tests (#298)
  chore(release): 1.29.0 [skip ci]
  feat(ci): enable TypeScript in Cypress tests (#297)
  remove browser cache hack preventing css from displaying correct logo (#293)
  chore(release): 1.28.2 [skip ci]
  fix(ui): never-ending loading animation on empty search (#260)
  ...

# Conflicts:
#	.github/workflows/nodejs.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
🌲 In production
Development

Successfully merging this pull request may close these issues.

None yet

1 participant