fix(ui): redirect error when landing on rankings page #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiuta
changed the title
compiuta
changed the title
|
Thanks for your pull request! I hope to review it this weekend, when I can
find some spare time :-)
Thanks for your contribution and patience ^^
Le mar. 7 avr. 2020 à 21:06, compiuta <notifications@github.com> a écrit :
Closes #21 <#21>
What does this PR do / solve?
Prevent redirect error and allow page to load for guest users
[image: Screenshot from 2020-04-07 11-59-52]
<https://user-images.githubusercontent.com/13477167/78708799-8ac1c080-78c7-11ea-82ee-f4165c3d9d10.png>
Overview of changes
I removed some conditions redirecting the user from
https://openwhyd.org/discover/ranking to
https://openwhyd.org/discover/featured.
Since this redirect was causing the page to throw an error instead of
actually loading the redirected page I would think it is best to just load
the rankings page. Then the user can click on the featured tab to go the
the featured page.
How to test this PR?
The page is now loading when a guest user goes to
https://openwhyd.org/discover/ranking
------------------------------
You can view, comment on, or merge this pull request online at:
#321
Commit Summary
- remove conditions causing a redirect error when landing on rankings
page
File Changes
- *M* app/controllers/discover.js
<https://github.com/openwhyd/openwhyd/pull/321/files#diff-08d15e63b20da11c26152d0ea5408d2c>
(83)
Patch Links:
- https://github.com/openwhyd/openwhyd/pull/321.patch
- https://github.com/openwhyd/openwhyd/pull/321.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#321>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEB2RNQ3MGAIE7MSNQUBALRLN2T5ANCNFSM4MDLQD7A>
.
--
Envoyé avec Gmail Mobile
|
adrienjoly
requested changes
Apr 15, 2020
adrienjoly
pushed a commit
that referenced
this pull request
Apr 16, 2020
## [1.34.2](v1.34.1...v1.34.2) (2020-04-16) ### Bug Fixes * **ui:** redirect error when landing on rankings page ([#321](#321)) ([8e6040e](8e6040e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
What does this PR do / solve?
Prevent redirect error and allow page to load for guest users
Overview of changes
I removed some conditions redirecting the user from
https://openwhyd.org/discover/ranking to https://openwhyd.org/discover/featured.
Since this redirect was causing the page to throw an error instead of actually loading the redirected page I would think it is best to just load the rankings page. Then the user can click on the featured tab to go the the featured page.
How to test this PR?
The page is now loading when a guest user goes to https://openwhyd.org/discover/ranking