Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): Force cypress v3.8.3 on the Docker Workflow #336

Merged
merged 1 commit into from
Aug 25, 2020
Merged

fix(CI): Force cypress v3.8.3 on the Docker Workflow #336

merged 1 commit into from
Aug 25, 2020

Conversation

Salayna
Copy link
Contributor

@Salayna Salayna commented Aug 25, 2020

Closes #333 .

What does this PR do / solve?

Forcing cypress version 3.8.3 on the Docker Workflow with npx

@Salayna Salayna changed the title fix: Force cypress v3.8.3 on the Docker Workflow Fix: Force cypress v3.8.3 on the Docker Workflow Aug 25, 2020
@adrienjoly adrienjoly changed the title Fix: Force cypress v3.8.3 on the Docker Workflow fix: Force cypress v3.8.3 on the Docker Workflow Aug 25, 2020
@adrienjoly adrienjoly changed the title fix: Force cypress v3.8.3 on the Docker Workflow fix(CI): Force cypress v3.8.3 on the Docker Workflow Aug 25, 2020
adrienjoly
adrienjoly approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrienjoly adrienjoly merged commit 63a3e1e into openwhyd:master Aug 25, 2020
adrienjoly pushed a commit that referenced this pull request Aug 25, 2020
@semantic-release-bot
chore(release): 1.34.5 [skip ci]
d6ba134 
## [1.34.5](v1.34.4...v1.34.5) (2020-08-25)

### Bug Fixes

* **CI:** Force cypress v3.8.3 on the Docker Workflow ([#336](#336)) ([63a3e1e](63a3e1e)), closes [#333](#333)
@adrienjoly adrienjoly added the bug label Aug 25, 2020
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Aug 25, 2020
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to ✔️ Done / pending QA in Development Aug 25, 2020
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienjoly adrienjoly adrienjoly approved these changes

Assignees

@Salayna Salayna

Labels
bug
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Cypress 5 => fix CI
2 participants
@Salayna @adrienjoly