fix(clean-up): Adjust ESLint/Codacy rules + fix some issues #346

adrienjoly · 2020-08-29T14:17:11Z

By:

fixing issues listed by $ npm run lint:fix
fixing issues listed by Codacy
removing code that is not used anymore

=> Resulting Codacy stats of this PR:

fixes 278 issues
removes 5 duplicated blocks
removes 9 complexity issues

Next steps:

fix HTML and CSS errors that are reported by prettier, especially in common.css
make sure that bookmarklet.js is analyzed by ESlint

https://app.codacy.com/gh/openwhyd/openwhyd/file/47813310408/issues/source?bid=17325385&fileBranchId=17325385#l81

…et object." https://app.codacy.com/gh/openwhyd/openwhyd/file/47813310597/issues/source?bid=17325385&fileBranchId=17325385#l383

https://app.codacy.com/gh/openwhyd/openwhyd/file/47814506445/issues/source?bid=17325385&fileBranchId=19945743#l117

https://app.codacy.com/gh/openwhyd/openwhyd/file/47814506561/issues/source?bid=17325385&fileBranchId=19945743#l175

(note: found issue #300 while formating with vscode)

to prevent issue #300

## [1.34.16](v1.34.15...v1.34.16) (2020-08-30) ### Bug Fixes * **clean-up:** Adjust ESLint/Codacy rules + fix some issues ([#346](#346)) ([c4d08a9](c4d08a9))

Follow up for PR #346. => no more syntax errors reported by `$(npm bin)/prettier . --write` 🎉 Also, it: - finishes the migration of the `bookmarklet` test from Webdriver to Cypress. - updates argon2 from v0.25.1 to v0.27.0, in order to prevent fix the broken download of binaries from GitHub releases - fixes "Uncaught ReferenceError: Barelog is not defined" on CI

## [1.34.17](v1.34.16...v1.34.17) (2020-08-30) ### Bug Fixes * **lint:** Fix ESLint & Codacy issues ([#348](#348)) ([440dda6](440dda6)), closes [#346](#346)

fix: just warn for "Move function declaration to function body root."

06077d3

https://app.codacy.com/gh/openwhyd/openwhyd/file/47813310408/issues/source?bid=17325385&fileBranchId=17325385#l81

adrienjoly changed the title ~~fix: just warn for "Move function declaration to function body root."~~ fix(clean-up): Adjust ESLint/Codacy rules + fix some issues Aug 29, 2020

adrienjoly added 24 commits August 29, 2020 16:34

🧹 remove old /discover and recommendation code

d0812a1

fix "Do not access Object.prototype method 'hasOwnProperty' from targ…

86d6363

…et object." https://app.codacy.com/gh/openwhyd/openwhyd/file/47813310597/issues/source?bid=17325385&fileBranchId=17325385#l383

fix other issues in snip.js

aadd4c9

fix: don't apply "no-var-requires" rule on TS files

6531912

fix(eslint): ignore jquery and other 3rd party js files

bedf3a2

fix issues in mongodb.js

20ecec0

fix snip.js: last self-->this

9f561e0

fix issues in user.js and metadataResolver.js

72b9c8f

fix eslint/no-unused-vars

1947389

fix eslint/no-this-alias

4ee25a4

fix lint/no-this-alias in fbGroupImport.js

3450bc3

fix "no-redeclare" + other eslint errors

d2b3bd9

fix "no-redeclare": for-var --> for-let

f436c84

fix: just skip imported playem files

37d4c50

fix no-redeclare

fa596cc

fix no-redeclare

e1ddd4f

fix "'i' is assigned a value but never used."

0f25485

https://app.codacy.com/gh/openwhyd/openwhyd/file/47814506445/issues/source?bid=17325385&fileBranchId=19945743#l117

fix "Unnecessary block."

e0a155a

https://app.codacy.com/gh/openwhyd/openwhyd/file/47814506561/issues/source?bid=17325385&fileBranchId=19945743#l175

fix no-redeclare

6ac4817

fix 'params' is not defined + other issues

e04e9d0

fix no-redeclare

8b3dbf3

fix no-undef

343e4d8

fix other eslint errors

f588143

fix eslint warnings

86a850e

adrienjoly mentioned this pull request Aug 29, 2020

Protect mustache/hogan blocks from being altered by prettier => prevent runtime errors #300

Closed

adrienjoly added 3 commits August 29, 2020 20:20

fix html and css issues found by prettier

d6b2097

(note: found issue #300 while formating with vscode)

let prettier fix html files

093009d

make vscode use prettier to format html files

9e66cfe

to prevent issue #300

adrienjoly added 2 commits August 29, 2020 20:34

fix mustache/hogan markup broken by vscode's formatting (#300)

d0454b0

let eslint try to fix html and css issues

888512e

adrienjoly self-assigned this Aug 30, 2020

adrienjoly added the enhancement label Aug 30, 2020

adrienjoly added this to 📥 Inbox / ideas in Development via automation Aug 30, 2020

adrienjoly moved this from 📥 Inbox / ideas to ⚙ In progress in Development Aug 30, 2020

adrienjoly added 2 commits August 30, 2020 11:09

Merge branch 'master' into fix/codacy-and-eslint-issues

257ab7e

Merge branch 'master' into fix/codacy-and-eslint-issues

43a2a1b

adrienjoly marked this pull request as ready for review August 30, 2020 09:21

adrienjoly merged commit c4d08a9 into master Aug 30, 2020

Development automation moved this from ⚙ In progress to ✔️ Done / pending QA Aug 30, 2020

adrienjoly deleted the fix/codacy-and-eslint-issues branch August 30, 2020 09:24

adrienjoly pushed a commit that referenced this pull request Aug 30, 2020

chore(release): 1.34.16 [skip ci]

1bcf406

## [1.34.16](v1.34.15...v1.34.16) (2020-08-30) ### Bug Fixes * **clean-up:** Adjust ESLint/Codacy rules + fix some issues ([#346](#346)) ([c4d08a9](c4d08a9))

adrienjoly mentioned this pull request Aug 30, 2020

fix(lint): Fix ESLint & Codacy issues #348

Merged

adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Aug 30, 2020

adrienjoly pushed a commit that referenced this pull request Aug 30, 2020

chore(release): 1.34.17 [skip ci]

82000b8

## [1.34.17](v1.34.16...v1.34.17) (2020-08-30) ### Bug Fixes * **lint:** Fix ESLint & Codacy issues ([#348](#348)) ([440dda6](440dda6)), closes [#346](#346)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(clean-up): Adjust ESLint/Codacy rules + fix some issues #346

fix(clean-up): Adjust ESLint/Codacy rules + fix some issues #346

adrienjoly commented Aug 29, 2020 •

edited

Loading

fix(clean-up): Adjust ESLint/Codacy rules + fix some issues #346

fix(clean-up): Adjust ESLint/Codacy rules + fix some issues #346

Conversation

adrienjoly commented Aug 29, 2020 • edited Loading

adrienjoly commented Aug 29, 2020 •

edited

Loading