fix(lint): Fix ESLint & Codacy issues #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienjoly
changed the title
"Pre-built binaries not found for argon2@0.25.1 and node@10.16.3 (node-v64 ABI, glibc) (falling back to source compile with node-gyp) " https://github.com/openwhyd/openwhyd/pull/348/checks?check_run_id=1047436708#step:3:812
adrienjoly
added a commit
that referenced
this pull request
Sep 6, 2020
* master: (251 commits) fix(logs): Remove or clarify old production + unit test logs (#365) chore(release): 1.35.0 [skip ci] feat: ⚰️ Bury collaborative playlists (never-finished feature) (#364) chore(release): 1.34.23 [skip ci] fix(logs): Reduce amount of logging in production (#363) chore(release): 1.34.22 [skip ci] fix(tests): Test avatar upload (#362) chore(release): 1.34.21 [skip ci] fix(logs): Re-import colors package, to prevent "undefined" entries in logs (#361) chore(release): 1.34.20 [skip ci] fix(deps): Update dependencies (#360) chore(prod): devDeps should not be installed in production fixes #256 chore(release): 1.34.19 [skip ci] fix(e2e-tests): Finish migration from Webdriver to Cypress (#358) chore(deps): bump handlebars from 4.4.0 to 4.7.6 (#357) chore(deps): bump bl from 2.2.0 to 2.2.1 (#353) chore(release): 1.34.18 [skip ci] fix(css): Remove obsolete definitions (#350) chore(release): 1.34.17 [skip ci] fix(lint): Fix ESLint & Codacy issues (#348) ... # Conflicts: # app/models/notif.js # test/unit/notif-tests.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for PR #346.
=> no more syntax errors reported by
$(npm bin)/prettier . --write🎉Also, it:
bookmarklettest from Webdriver to Cypress.