Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Remove obsolete CSS definitions #350

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Aug 30, 2020

And fix syntax errors.

@adrienjoly adrienjoly self-assigned this Aug 30, 2020
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Aug 30, 2020
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to ⚙ In progress in Development Aug 30, 2020
@adrienjoly adrienjoly marked this pull request as ready for review August 30, 2020 17:45
@adrienjoly adrienjoly moved this from ⚙ In progress to ✔️ Done / pending QA in Development Aug 30, 2020
@adrienjoly adrienjoly changed the title fix(css): Remove obsolete definitions fix(css): Remove obsolete CSS definitions [Feedback is welcome] Aug 30, 2020
@adrienjoly adrienjoly changed the title fix(css): Remove obsolete CSS definitions [Feedback is welcome] fix(css): Remove obsolete CSS definitions Sep 1, 2020
@@ -3140,7 +2943,7 @@ body.pgWithSideBar .post > h2 {
cursor: pointer;
}

.post .ext .stats > .:hover {
Copy link
Member Author

@adrienjoly adrienjoly Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a syntax error

border: none;
zoom: 1;
*display: inline;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a syntax error

@adrienjoly adrienjoly merged commit 44d4445 into master Sep 1, 2020
@adrienjoly adrienjoly deleted the fix/common-css branch September 1, 2020 13:52
adrienjoly pushed a commit that referenced this pull request Sep 1, 2020
## [1.34.18](v1.34.17...v1.34.18) (2020-09-01)

### Bug Fixes

* **css:** Remove obsolete definitions ([#350](#350)) ([44d4445](44d4445))
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Sep 1, 2020
adrienjoly added a commit that referenced this pull request Sep 6, 2020
* master: (251 commits)
  fix(logs): Remove or clarify old production + unit test logs (#365)
  chore(release): 1.35.0 [skip ci]
  feat: ⚰️ Bury collaborative playlists (never-finished feature) (#364)
  chore(release): 1.34.23 [skip ci]
  fix(logs): Reduce amount of logging in production (#363)
  chore(release): 1.34.22 [skip ci]
  fix(tests): Test avatar upload (#362)
  chore(release): 1.34.21 [skip ci]
  fix(logs): Re-import colors package, to prevent "undefined" entries in logs (#361)
  chore(release): 1.34.20 [skip ci]
  fix(deps): Update dependencies (#360)
  chore(prod): devDeps should not be installed in production fixes #256
  chore(release): 1.34.19 [skip ci]
  fix(e2e-tests): Finish migration from Webdriver to Cypress (#358)
  chore(deps): bump handlebars from 4.4.0 to 4.7.6 (#357)
  chore(deps): bump bl from 2.2.0 to 2.2.1 (#353)
  chore(release): 1.34.18 [skip ci]
  fix(css): Remove obsolete definitions (#350)
  chore(release): 1.34.17 [skip ci]
  fix(lint): Fix ESLint & Codacy issues (#348)
  ...

# Conflicts:
#	app/models/notif.js
#	test/unit/notif-tests.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
🌲 In production
Development

Successfully merging this pull request may close these issues.

None yet

1 participant