Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e-tests): Finish migration from Webdriver to Cypress #358

Merged
merged 7 commits into from
Sep 5, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Sep 5, 2020

Closes #199.

And also updates Cypress from version 3.x to 5.1.

Note: diff is big mostly because of package-lock.json.

@adrienjoly adrienjoly self-assigned this Sep 5, 2020
@adrienjoly adrienjoly changed the title tests: migrate working webdriver tests to cypress test: migrate working webdriver tests to cypress Sep 5, 2020
@adrienjoly adrienjoly changed the title test: migrate working webdriver tests to cypress fix(e2e-tests): migrate working webdriver tests to cypress Sep 5, 2020
@adrienjoly
Copy link
Member Author

Last execution of tests on CI with Cypress 3.x:

image

First execution of tests on CI with Cypress 5.1, without generating video or screenshots:

image

@adrienjoly adrienjoly changed the title fix(e2e-tests): migrate working webdriver tests to cypress fix(e2e-tests): Finish migration from Webdriver to Cypress Sep 5, 2020
@adrienjoly
Copy link
Member Author

adrienjoly commented Sep 5, 2020

CI execution time comparison

before PR after PR
"Automated tests" workflow 1m24 52s
"Cypress E2E tests" workflow 3m05 2mn11

@adrienjoly adrienjoly marked this pull request as ready for review September 5, 2020 12:09
@adrienjoly adrienjoly merged commit 5eccaa7 into master Sep 5, 2020
@adrienjoly adrienjoly deleted the tests/199-migrate-last-webdriver-test-to-cypress branch September 5, 2020 12:09
adrienjoly pushed a commit that referenced this pull request Sep 5, 2020
## [1.34.19](v1.34.18...v1.34.19) (2020-09-05)

### Bug Fixes

* **e2e-tests:** Finish migration from Webdriver to Cypress ([#358](#358)) ([5eccaa7](5eccaa7)), closes [#199](#199)
adrienjoly added a commit that referenced this pull request Sep 5, 2020
Follow up of PR #358. Contributes to #199.

Also:
- removes all Webdriver leftovers;
- converts all Cypress support files to TypeScript;
- stops running Cypress tests from the "Docker" CI workflow. (too complicated for too little added value)
adrienjoly pushed a commit that referenced this pull request Sep 5, 2020
## [1.34.22](v1.34.21...v1.34.22) (2020-09-05)

### Bug Fixes

* **tests:** Test avatar upload ([#362](#362)) ([04c4f91](04c4f91)), closes [#358](#358) [#199](#199)
adrienjoly added a commit that referenced this pull request Sep 6, 2020
* master: (251 commits)
  fix(logs): Remove or clarify old production + unit test logs (#365)
  chore(release): 1.35.0 [skip ci]
  feat: ⚰️ Bury collaborative playlists (never-finished feature) (#364)
  chore(release): 1.34.23 [skip ci]
  fix(logs): Reduce amount of logging in production (#363)
  chore(release): 1.34.22 [skip ci]
  fix(tests): Test avatar upload (#362)
  chore(release): 1.34.21 [skip ci]
  fix(logs): Re-import colors package, to prevent "undefined" entries in logs (#361)
  chore(release): 1.34.20 [skip ci]
  fix(deps): Update dependencies (#360)
  chore(prod): devDeps should not be installed in production fixes #256
  chore(release): 1.34.19 [skip ci]
  fix(e2e-tests): Finish migration from Webdriver to Cypress (#358)
  chore(deps): bump handlebars from 4.4.0 to 4.7.6 (#357)
  chore(deps): bump bl from 2.2.0 to 2.2.1 (#353)
  chore(release): 1.34.18 [skip ci]
  fix(css): Remove obsolete definitions (#350)
  chore(release): 1.34.17 [skip ci]
  fix(lint): Fix ESLint & Codacy issues (#348)
  ...

# Conflicts:
#	app/models/notif.js
#	test/unit/notif-tests.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate e2e tests from Webdriver to Cypress
1 participant