Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Test avatar upload #362

Merged
merged 19 commits into from
Sep 5, 2020
Merged

fix(tests): Test avatar upload #362

merged 19 commits into from
Sep 5, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Sep 5, 2020 •
edited
Loading

Also:

  • removes all Webdriver leftovers;
  • converts all Cypress support files to TypeScript;
  • stops running Cypress tests from the "Docker" CI workflow. (too complicated for too little added value)

@adrienjoly adrienjoly self-assigned this Sep 5, 2020
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Sep 5, 2020
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to ⚙ In progress in Development Sep 5, 2020
@adrienjoly adrienjoly changed the title upload an avatar from cypress, with "cypress-file-upload" plugin fix(tests): Test avatar upload Sep 5, 2020
@adrienjoly
fix SecurityError: Blocked a frame with origin "http://localhost:8080…
9f8525c 
…" from accessing a cross-origin frame

... at least when testing locally with `npm run docker:test:cypress:dev`
@adrienjoly
move sample images to cypress' fixtures dir
b5872e6
@adrienjoly
fix "Cannot find module 'cypress-file-upload'" on Docker CI workflow
9985cb8 
https://github.com/openwhyd/openwhyd/pull/362/checks?check_run_id=1075778172#step:7:41
@adrienjoly
check that the avatar changed. (FYI: it fails locally)
2b5694f
@adrienjoly
fix: attachFile() to be recognized by vscode, by converting all files…
be3fecd 
… to TS
@adrienjoly
fix "You are attempting to run a TypeScript file, but do not have Typ…
663292b 
…eScript installed" error on CI

https://github.com/openwhyd/openwhyd/runs/1075789871#step:7:34
@adrienjoly
the upload works!
d0e1cc1 
https://stackoverflow.com/a/62204487/592254
@adrienjoly
fix "cypress: not found" on CI
92d54f2 
https://github.com/openwhyd/openwhyd/runs/1075812691#step:7:8
@adrienjoly
fix "Your system is missing the dependency: Xvfb" on CI
689cfdc 
https://github.com/openwhyd/openwhyd/pull/362/checks?check_run_id=1075829822#step:7:468
@adrienjoly
fix "are you root?" error on CI
b04fada 
https://github.com/openwhyd/openwhyd/pull/362/checks?check_run_id=1075846530#step:7:7
@adrienjoly
oops, forgot to run apt in the container
5dbefdd
@adrienjoly
fix loading of cypress types
f54cb58
@adrienjoly
fix "sudo not found" on CI
bcf4fec
@adrienjoly
simplify the upload test
707b76a
@adrienjoly
weird errors on CI => run cypress from host
2bf7e23 
https://github.com/openwhyd/openwhyd/pull/362/checks?check_run_id=1075876093#step:7:1415
@adrienjoly
try to run npm run docker:test in Docker CI workflow
b4d7ef6
@adrienjoly
stop trying to run cypress tests in the Docker CI workflow
205b848
@adrienjoly
Merge branch 'master' into fix/test-upload
22bdaca
@adrienjoly adrienjoly marked this pull request as ready for review September 5, 2020 17:04
@adrienjoly adrienjoly merged commit 04c4f91 into master Sep 5, 2020
Development automation moved this from ⚙ In progress to ✔️ Done / pending QA Sep 5, 2020
@adrienjoly adrienjoly deleted the fix/test-upload branch September 5, 2020 17:05
adrienjoly pushed a commit that referenced this pull request Sep 5, 2020
@semantic-release-bot
chore(release): 1.34.22 [skip ci]
85b3f07 
## [1.34.22](v1.34.21...v1.34.22) (2020-09-05)

### Bug Fixes

* **tests:** Test avatar upload ([#362](#362)) ([04c4f91](04c4f91)), closes [#358](#358) [#199](#199)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Sep 5, 2020
adrienjoly added a commit that referenced this pull request Sep 6, 2020
@adrienjoly
Merge branch 'master' into pr/agathe-vaisse/326
0304c3d 
* master: (251 commits)
  fix(logs): Remove or clarify old production + unit test logs (#365)
  chore(release): 1.35.0 [skip ci]
  feat: ⚰️ Bury collaborative playlists (never-finished feature) (#364)
  chore(release): 1.34.23 [skip ci]
  fix(logs): Reduce amount of logging in production (#363)
  chore(release): 1.34.22 [skip ci]
  fix(tests): Test avatar upload (#362)
  chore(release): 1.34.21 [skip ci]
  fix(logs): Re-import colors package, to prevent "undefined" entries in logs (#361)
  chore(release): 1.34.20 [skip ci]
  fix(deps): Update dependencies (#360)
  chore(prod): devDeps should not be installed in production fixes #256
  chore(release): 1.34.19 [skip ci]
  fix(e2e-tests): Finish migration from Webdriver to Cypress (#358)
  chore(deps): bump handlebars from 4.4.0 to 4.7.6 (#357)
  chore(deps): bump bl from 2.2.0 to 2.2.1 (#353)
  chore(release): 1.34.18 [skip ci]
  fix(css): Remove obsolete definitions (#350)
  chore(release): 1.34.17 [skip ci]
  fix(lint): Fix ESLint & Codacy issues (#348)
  ...

# Conflicts:
#	app/models/notif.js
#	test/unit/notif-tests.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
enhancement
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adrienjoly