Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bandcamp): Fetch the stream URL from the track's page #394

Merged
merged 8 commits into from
Nov 15, 2020
Merged

fix(bandcamp): Fetch the stream URL from the track's page #394

merged 8 commits into from
Nov 15, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Nov 15, 2020 •
edited
Loading

Fixes #117.

Also cleans up old content/embed extraction code.

@adrienjoly adrienjoly self-assigned this Nov 15, 2020
@adrienjoly adrienjoly changed the title 🧹 delete ContentEmbedWrapper + move getMp3s() from lib/get to api/contentExtractor fix: Clean-up content/embed extraction code Nov 15, 2020
@adrienjoly adrienjoly changed the title fix: Clean-up content/embed extraction code fix(bandcamp): Fetch the stream URL from the track's page Nov 15, 2020
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Nov 15, 2020
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to ⚙ In progress in Development Nov 15, 2020
@adrienjoly adrienjoly marked this pull request as ready for review November 15, 2020 17:11
@adrienjoly adrienjoly merged commit 439304f into master Nov 15, 2020
Development automation moved this from ⚙ In progress to ✔️ Done / pending QA Nov 15, 2020
@adrienjoly adrienjoly deleted the fix/bandcamp-stream-getter branch November 15, 2020 17:12
adrienjoly pushed a commit that referenced this pull request Nov 15, 2020
@semantic-release-bot
chore(release): 1.40.5 [skip ci]
fea614e 
## [1.40.5](v1.40.4...v1.40.5) (2020-11-15)

### Bug Fixes

* **bandcamp:** Fetch the stream URL from the track's page ([#394](#394)) ([439304f](439304f)), closes [#117](#117)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
enhancement
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bandcamp tracks playback fail
1 participant
@adrienjoly