fix(api): Regression on Data Export API + side effects between API tests #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienjoly
changed the title
adrienjoly
changed the title
adrienjoly
pushed a commit
that referenced
this pull request
Dec 19, 2020
## [1.44.9](v1.44.8...v1.44.9) (2020-12-19) ### Bug Fixes * **api:** Regression on Data Export API + side effects between API tests ([#418](#418)) ([f4f1466](f4f1466))
adrienjoly
added a commit
that referenced
this pull request
Dec 19, 2020
…sts (#418) * local optim: run docker:seed just once * test: "data export api provides profile tracks of given user id" * Revert "local optim: run docker:seed just once" This reverts commit 93d9f65. * test: "provides profile tracks of given user id, as a list of links" * add same tests by username instead of user_id * new tests: "provides playlist tracks of given user id" * same, with username => error because "admin" user handle conflicts with admin routes * => use DUMMY_USER to prevent conflict between handle and admin routes => "User not found..." error * fix: don't let the presence of a playlistId preempt the retrieval of user by their handle * add links to API docs * fix: use DUMMY_USER instead of ADMIN_USER in post.api.tests.js * extract data.api.tests.js from user.api.tests.js * ❌ new test: "provides list of playlists" * fix: make the /playlists handler return the actual list of playlists * /playlists route now works in JSON format * fix tests * fix test expectation * normalize formatting conditions * make "bareFormats" ('json' / 'links') easier to find * clean up playlist processing logic (cherry picked from commit f4f1466)
adrienjoly
added a commit
that referenced
this pull request
Dec 19, 2020
…n API tests (#419) Re-apply PR #418 with hotfix. Problem: error when trying to open https://openwhyd.org/adrien/playlist: - error while calling "_id.getTimestamp()", at ` var when = post._id ? post._id.getTimestamp().getTime() : undefined;` (`app/templates/posts.js`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / solve?
openwhyd-pl-dl does not work anymore because thethat's actually ok$PROFILE_URL/playlists?format=listroute returns an HTML page instead of the list of playlists for that user.Related observation:Problem: https://openwhyd.org/adrien/playlist/1?format=json return{"errorCode":"USER_NOT_FOUND","error":"User not found..."}, while https://openwhyd.org/u/4d94501d1f78ac091dbc9b4d/playlist/1?format=json returns the tracklist as expected.