Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Cypress 6.3.0 #428

Merged
merged 3 commits into from
Jan 23, 2021
Merged

fix(deps): Cypress 6.3.0 #428

merged 3 commits into from
Jan 23, 2021

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Jan 17, 2021 •
edited
Loading

@adrienjoly
Copy link
Member Author

adrienjoly commented Jan 17, 2021 •
edited
Loading

Visual tests fail because the last snapshot (/button page) is not uploaded, for some reason.

Capture d’écran 2021-01-17 à 19 59 07

cf https://github.com/openwhyd/openwhyd/pull/428/checks?check_run_id=1717652914#step:8:126

@adrienjoly
Copy link
Member Author

adrienjoly commented Jan 18, 2021 •
edited
Loading

Hypothesis: the after.all hooks does not wait any longer for applitools to receive the last snapshots. => ask https://help.applitools.com/hc/en-us/requests/new

Or it could be caused by a breaking change from Cypress 6: https://github.com/cypress-io/cypress/releases/tag/v6.0.0

@adrienjoly adrienjoly changed the title fix(deps): cypress 6.2.1 fix(deps): Cypress 6.3.0 Jan 23, 2021
@adrienjoly adrienjoly marked this pull request as ready for review January 23, 2021 17:43
@adrienjoly adrienjoly merged commit ca64506 into master Jan 23, 2021
@adrienjoly adrienjoly deleted the fix/deps-cypress branch January 23, 2021 17:43
adrienjoly pushed a commit that referenced this pull request Jan 23, 2021
@semantic-release-bot
chore(release): 1.44.26 [skip ci]
f040cf5 
## [1.44.26](v1.44.25...v1.44.26) (2021-01-23)

### Bug Fixes

* **deps:** Cypress 6.3.0 ([#428](#428)) ([ca64506](ca64506)), closes [/docs.cypress.io/guides/references/changelog.html#6-3-0](https://github.com//docs.cypress.io/guides/references/changelog.html/issues/6-3-0)
@adrienjoly adrienjoly self-assigned this Jan 23, 2021
@adrienjoly adrienjoly added the dependencies Pull requests that update a dependency file label Jan 23, 2021
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Jan 23, 2021
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to 🌲 In production in Development Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
dependencies Pull requests that update a dependency file
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adrienjoly