fix(ci): Detect TS errors and check code quality & formatting in CI #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=> to prevent eslint from failing (for now) /Users/adrienjoly/dev/openwhyd/openwhyd/app/snip.js 800:5 error Variables should not be deleted no-delete-var
…into fix/ci-linter * 'fix/ci-linter' of https://github.com/openwhyd/openwhyd: chore(release): 1.44.22 [skip ci] fix(ci): Revert Applitools configuration for GitHub integration (#436) chore(release): 1.44.21 [skip ci] fix(ci): Add APPLITOOLS_BATCH_ID env var (#432) chore(release): 1.44.20 [skip ci] fix(UI): Search results blocked by header, when visiting the home page (#435) chore(release): 1.44.19 [skip ci] fix(ci): Don't npm install unless we publish to Docker Hub (#431) chore(release): 1.44.18 [skip ci] fix(deps): Update mongodb 3.1.13 --> 3.6.3 (#427)
|
Results of execution in GitHub Actions CI:
|
adrienjoly
changed the title
adrienjoly
pushed a commit
that referenced
this pull request
Jan 23, 2021
## [1.44.23](v1.44.22...v1.44.23) (2021-01-23) ### Bug Fixes * **ci:** Detect TS errors and check code quality & formatting in CI ([#430](#430)) ([c4b4dee](c4b4dee))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect TypeScript errors and prevent regressions of code quality in Pull Requests / CI.
npx tsc --noEmiton CI