Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Add APPLITOOLS_BATCH_ID env var #432

Merged
merged 10 commits into from
Jan 23, 2021
Merged

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Jan 18, 2021

Goal: fix failed CI check from Applitools after merging each PR.

applitools

Source: https://applitools.com/docs/topics/integrations/github-integration-ci-setup.html

@adrienjoly adrienjoly self-assigned this Jan 18, 2021
@adrienjoly adrienjoly added the bug label Jan 18, 2021
@adrienjoly
Copy link
Member Author

adrienjoly commented Jan 18, 2021

Error:

  Running:  visual-snapshots.ts                                                             (2 of 7)
  Estimated: 17 seconds


  Visual Snapshots
    1) "before all" hook for "visitor"


  0 passing (4s)
  1 failing

  1) Visual Snapshots
       "before all" hook for "visitor":
     Error: connect ECONNREFUSED 127.0.0.1:80

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Visual Snapshots`
      at eval (http://localhost:8080/__cypress/tests?p=cypress/support/index.ts:1186:17)

Source: https://github.com/openwhyd/openwhyd/pull/432/checks?check_run_id=1720895721#step:8:120

@adrienjoly adrienjoly marked this pull request as ready for review January 23, 2021 14:04
@adrienjoly adrienjoly merged commit 816e7ff into master Jan 23, 2021
@adrienjoly adrienjoly deleted the fix/ci-applitools-batchid branch January 23, 2021 14:05
adrienjoly added a commit that referenced this pull request Jan 23, 2021
adrienjoly pushed a commit that referenced this pull request Jan 23, 2021
## [1.44.21](v1.44.20...v1.44.21) (2021-01-23)

### Bug Fixes

* **ci:** Add APPLITOOLS_BATCH_ID env var ([#432](#432)) ([816e7ff](816e7ff))
adrienjoly added a commit that referenced this pull request Jan 23, 2021
This reverts changes from PR #432, because the error happened again after merging to master.

I also disabled github integration from Applitools' admin.
adrienjoly pushed a commit that referenced this pull request Jan 23, 2021
## [1.44.22](v1.44.21...v1.44.22) (2021-01-23)

### Bug Fixes

* **ci:** Revert Applitools configuration for GitHub integration ([#436](#436)) ([aaa04f6](aaa04f6)), closes [#432](#432)
adrienjoly added a commit that referenced this pull request Jan 23, 2021
…into fix/ci-linter

* 'fix/ci-linter' of https://github.com/openwhyd/openwhyd:
  chore(release): 1.44.22 [skip ci]
  fix(ci): Revert Applitools configuration for GitHub integration (#436)
  chore(release): 1.44.21 [skip ci]
  fix(ci): Add APPLITOOLS_BATCH_ID env var (#432)
  chore(release): 1.44.20 [skip ci]
  fix(UI): Search results blocked by header, when visiting the home page (#435)
  chore(release): 1.44.19 [skip ci]
  fix(ci): Don't npm install unless we publish to Docker Hub (#431)
  chore(release): 1.44.18 [skip ci]
  fix(deps): Update mongodb 3.1.13 --> 3.6.3 (#427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant