Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): allow selection of previously blocked items in search results div #435

Merged

Conversation

alightsleeper
Copy link
Contributor

Closes #434 .

What does this PR do / solve?

Adds a z-index to the searchResults div, to allow selecting of the previously blocked item.

Overview of changes

How to test this PR?

I tested this in the browser, just adding a z-index of 1 in common.css

@alightsleeper alightsleeper changed the title fix for issue #434 fix(UI): allow selection of previously blocked items in search results div Jan 23, 2021
Copy link
Member

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully ran the tests tested this fix locally. LGTM

Thank you for your contribution! 🙌

@adrienjoly adrienjoly merged commit 13745d5 into openwhyd:master Jan 23, 2021
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Jan 23, 2021
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to ✔️ Done / pending QA in Development Jan 23, 2021
adrienjoly pushed a commit that referenced this pull request Jan 23, 2021
## [1.44.20](v1.44.19...v1.44.20) (2021-01-23)

### Bug Fixes

* **UI:** Search results blocked by header, when visiting the home page ([#435](#435)) ([13745d5](13745d5))
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Jan 23, 2021
adrienjoly added a commit that referenced this pull request Jan 23, 2021
…into fix/ci-linter

* 'fix/ci-linter' of https://github.com/openwhyd/openwhyd:
  chore(release): 1.44.22 [skip ci]
  fix(ci): Revert Applitools configuration for GitHub integration (#436)
  chore(release): 1.44.21 [skip ci]
  fix(ci): Add APPLITOOLS_BATCH_ID env var (#432)
  chore(release): 1.44.20 [skip ci]
  fix(UI): Search results blocked by header, when visiting the home page (#435)
  chore(release): 1.44.19 [skip ci]
  fix(ci): Don't npm install unless we publish to Docker Hub (#431)
  chore(release): 1.44.18 [skip ci]
  fix(deps): Update mongodb 3.1.13 --> 3.6.3 (#427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development
  
🌲 In production
Development

Successfully merging this pull request may close these issues.

homeHeader div on main page blocks selecting items in the searchResults div
2 participants