This repository has been archived by the owner on May 19, 2020. It is now read-only.
[admin/models] Implement nested subnets #21
Labels
help wanted
Extra attention is needed
Comments
I'm totally agree, the master subnet with nested subnets cloud be implemented in the future. |
@hispanico shall we start defining how to implement this feature?
|
The python's ipaddress module provides some helpful functions, like |
nemesifier
changed the title
[admin/models] Master subnet improvements
[admin/models] Implement nested subnets
Jul 29, 2018
@nemesisdesign @hispanico the subnet and master subnet validation checks are done on my local branch, but I am not sure about the visualizations, how do they work in case of master subnet and subnets, could explain a bit more? |
atb00ker
moved this from To do (general)
to To do (python & django)
in OpenWISP Contributor's Board
Jan 1, 2019
atb00ker
moved this from In progress
to Needs review
in OpenWISP Priorities for next releases
Jan 3, 2019
@atb00ker that looks great! Is a PR already open for that? |
AFAIK this can be closed. |
OpenWISP Contributor's Board
automation
moved this from To do (Python & Django)
to Done
Feb 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@hispanico what is the purpose of the master subnet field?
Right now I think the current implementation doesn't really do much with it, infact I can select pretty much any rubbish value and the system will accept it. Implementing this correctly will take effort because we'll also probably need to have any subnet which is flagged as master (by another subnet) to show part of its address space occupied.
I suggest removing it temporarily and discuss of how it should be properly implemented.
The text was updated successfully, but these errors were encountered: