Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monitoring] Device metric collection view should be a POST #35

Closed
nemesifier opened this issue Apr 16, 2020 · 1 comment
Closed

[monitoring] Device metric collection view should be a POST #35

nemesifier opened this issue Apr 16, 2020 · 1 comment

Comments

@nemesifier
Copy link
Member

nemesifier commented Apr 16, 2020

This should be a POST and not a GET:

Tests have to be updated accordingly, devices will have to be updated as well.

Let's provide backward compatibility for the GET, but using logger.warning() to suggest to upgrade.

The lua monitoring scripts will also have to be upgraded: openwisp/openwrt-openwisp-monitoring#4

@nemesifier
Copy link
Member Author

nemesifier commented Apr 20, 2020

Working too much is unhealthy.. (It's a POST already.)

OpenWISP Contributor's Board automation moved this from To do (general) to Done Apr 20, 2020
OpenWISP Priorities for next releases automation moved this from To do to Done Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant