Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Canvas update #331

Open
afonsobspinto opened this issue Aug 10, 2020 · 0 comments
Open

Optimize Canvas update #331

afonsobspinto opened this issue Aug 10, 2020 · 0 comments
Labels
enhancement New feature or request
Projects
Geppetto client roadmap

Comments

@afonsobspinto
Copy link
Member

When we change the content of the data prop of the canvas component, one of two things could have happened:

  1. Instances were added/removed
  2. The attributes of the instances already present in the scene were changed

For the first case, adding instances that are not yet in the scene requires traversing the instance's hierarchy. While the second one, doesn't.
Currently, we are always traversing the instances but that can be optimized.
@afonsobspinto afonsobspinto added the enhancement New feature or request label Aug 10, 2020
@afonsobspinto afonsobspinto added this to Proposal in Geppetto client roadmap via automation Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Geppetto client roadmap
  
Proposal
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afonsobspinto