Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitize the figure mentioned in #31 #40

Closed
travs opened this issue Jun 21, 2015 · 7 comments
Closed

Digitize the figure mentioned in #31 #40

travs opened this issue Jun 21, 2015 · 7 comments

Comments

@travs
Copy link

travs commented Jun 21, 2015

A walkthrough of digitizing is online.

The figure is in #31 -- it can also be extracted again from the original paper, which is linked there.

@rayner
Copy link
Contributor

rayner commented Jun 22, 2015

Done. Sanity checks would be appreciated. My method was:

  1. View original paper in PDF format at 400% magnification.
  2. Take a screenshot of Figure 1A (in PNG format).
  3. Edit the image to superimpose the scale onto the two parts of the figure. This was done so that the "known points" for the WebPlotDigitizer app could be set in sensible places (starting at zero current, and with the onset of the pulse at zero seconds).
  4. Digitize each part of the figure as described in the walkthrough. The figure doesn't have the original data points marked, so I placed points in the salient features of the trace (start, end, pulse onset, peak, and along the decay curves).

Links to digitized data on Plotly:
https://plot.ly/~rayner/6
https://plot.ly/~rayner/11

Screenshot of figure 1A (step 2 above):
1a

Edited screenshot with scale superimposed (step 3 above):
1a-edited

@travs
Copy link
Author

travs commented Jun 23, 2015

@rayner
Great! Thank you!
I've compared your plots with the literature graphs and they do indeed appear sane 😄

Superimposing the axis onto the plot was a good call, as well as using the key features of a graph since no original data points were available. These should be considered best practices when digitizing further plots of this type, and thus should be included in the walkthrough.
I've raised VahidGh/ChannelWorm#98 in this regard.

This allows for #41 and #42 to happen when #31 is resolved.

@travs
Copy link
Author

travs commented Jun 23, 2015

The current milestone is actually blocked by #31.

Is #31 something you would be interested in trying, @rayner ? Or is there something else you find more interesting?

@rayner
Copy link
Contributor

rayner commented Jun 25, 2015

Thanks for the review, much appreciated. #31 looks like something I could contribute to. I'll set aside some time to work on it over the weekend.

@travs
Copy link
Author

travs commented Jun 30, 2015

@rayner
Hey Rayner, did you get a chance to look at #31 over the weekend?

@rayner
Copy link
Contributor

rayner commented Jul 1, 2015

A bit, yes. I've got the latest version of the muscle model now, and have been figuring out how to approach this using a LEMS model. It looks like we need something similar to the voltage clamp simulation defined in LEMS_Figure2B.xml, but with the addition of needing to account for the light-sensitive channels. I should be able to work on it a bit more tomorrow.

@travs
Copy link
Author

travs commented Jul 2, 2015

@rayner
Ok, since you're started on it I've "assigned" you to #31, Rayner. Let me know over there if there's anything I can do to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants