Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape mismatch after NaN filter: posture.primary_wavelength #114

Closed
MichaelCurrie opened this issue Feb 26, 2015 · 5 comments
Closed

Shape mismatch after NaN filter: posture.primary_wavelength #114

MichaelCurrie opened this issue Feb 26, 2015 · 5 comments
Assignees
Labels

Comments

@MichaelCurrie
Copy link

Running validate_features.py, I get the following output:

Calculating Morphology Features
Calculating Locomotion Features
Calculating Posture Features
Calculating Path Features

Comparison of computed features to those computed with old Matlab code
Locomotion: True
Shape mismatch after NaN filter: posture.primary_wavelength
Shape mismatch after NaN filter: posture.secondary_wavelength
Posture: False
Morphology: True
Path: True

I get this output whether or not user_config.py has
PERFORM_SLOW_ECCENTRICITY_CALC = False or
PERFORM_SLOW_ECCENTRICITY_CALC = True.

@MichaelCurrie
Copy link
Author

Now I'm getting a different error. Jim I hope you don't mind me assigning you to this, feel free to unassign if you prefer not to do it.

Calculating Morphology Features
Calculating Locomotion Features
Calculating Posture Features
Calculating Path Features

Comparison of computed features to those computed with old Matlab code
Shape mismatch (1,) vs (2,): locomotion.turns.upsilons.start_frames
Mismatch in locomotion.turns events
Locomotion: False
Posture: None
Morphology: True
Path: True

Done validating features
Time elapsed: 47.69 seconds

@JimHokanson
Copy link
Collaborator

This turned out to be an error introduced by @MichaelCurrie 😛

In all fairness one of us had written != None when in reality is not None is the appropriate way of writing this. It had been changed to look for numpy arrays which doesn't work with scalar inputs

@tarelli tarelli removed the ready label Jul 2, 2015
@JimHokanson
Copy link
Collaborator

We need to change the example to throw an example if the comparisons fail for Travis testing, see #146

@MichaelCurrie
Copy link
Author

Oops! Nice catch.

@MichaelCurrie
Copy link
Author

A remaining error: Posture returns None (see above)

The cause is that posture.bends.__eq__ was not implemented.

I fixed this with 3dfde14, now the tests pass, see #146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants