Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible deprecation messages and duplicated functions #182

Open
ver228 opened this issue Apr 8, 2016 · 2 comments
Open

Visible deprecation messages and duplicated functions #182

ver228 opened this issue Apr 8, 2016 · 2 comments

Comments

@ver228
Copy link
Contributor

ver228 commented Apr 8, 2016

I start to received a lot of of VisibleDeprecationWarnings. In an effort to corrected I start to modify the locomotion_bends file and find that the functions h__getBendData and h__getBandwidth, are duplicated in LocomotionCrawlingBends and in CrawlingBend.

This not only increases the size of the code but gives the possibility of slowly degenerating the functions until they are not longer the same. I propose to merge this function into a new object call BendHelper and make it the parent of LocomotionCrawlingBends and CrawlingBend.

I did the modification already. If it is find for you I'll make a pull request.

@MichaelCurrie
Copy link

@ver228 sounds great, feel free to do a PR and we can check it out.

@MichaelCurrie MichaelCurrie changed the title Visible deprecation messanges and duplicated functions Visible deprecation messages and duplicated functions Apr 15, 2016
@MichaelCurrie
Copy link

MichaelCurrie commented Sep 30, 2016

@ver228 can you please submit the PR or close this issue? Thanks very much!

@mwatts15 mwatts15 added this to Backlog in movement_validation Apr 13, 2019
@mwatts15 mwatts15 added this to Backlog in OpenWorm Top-level Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants