You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I start to received a lot of of VisibleDeprecationWarnings. In an effort to corrected I start to modify the locomotion_bends file and find that the functions h__getBendData and h__getBandwidth, are duplicated in LocomotionCrawlingBends and in CrawlingBend.
This not only increases the size of the code but gives the possibility of slowly degenerating the functions until they are not longer the same. I propose to merge this function into a new object call BendHelper and make it the parent of LocomotionCrawlingBends and CrawlingBend.
I did the modification already. If it is find for you I'll make a pull request.
The text was updated successfully, but these errors were encountered:
@ver228 sounds great, feel free to do a PR and we can check it out.
MichaelCurrie
changed the title
Visible deprecation messanges and duplicated functions
Visible deprecation messages and duplicated functions
Apr 15, 2016
I start to received a lot of of VisibleDeprecationWarnings. In an effort to corrected I start to modify the locomotion_bends file and find that the functions h__getBendData and h__getBandwidth, are duplicated in LocomotionCrawlingBends and in CrawlingBend.
This not only increases the size of the code but gives the possibility of slowly degenerating the functions until they are not longer the same. I propose to merge this function into a new object call BendHelper and make it the parent of LocomotionCrawlingBends and CrawlingBend.
I did the modification already. If it is find for you I'll make a pull request.
The text was updated successfully, but these errors were encountered: