-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure WebExtensions inject content script instrumentation before any page scripts run #242
Comments
In #291 we enabled "testing mode" for all content script injections. When we fix this, we should reverse that and rely on the |
As far as I (and @nhnt11) could determine, this should not be an issue with the current implementation, as soon as the extension is fully loaded. |
@jallmann Thanks for that investigation! I'm curious - could you share your test extension somewhere? Did you try putting a small delay in the content script and then checking if page scripts are affected by that delay? |
This is the extension I built for testing: The repo includes a test page and script with some console prints to illustrate the order of events.
I not sure what you mean. Some artificial, blocking delay in the content script? I haven't tried that, but I would expect it to delay page script execution as well. |
Thanks!
That sounds right. 👍
Yup, that's what I meant. |
Yes, blocking the content script for some time delays execution of the page script as well, just as expected. |
I think we can close this! |
The instrumentation should block page script execution until all of the instrumentation injected by the
js_instrument
is set up. We should determine whether this is actually an issue or if we are only experience this during the initial page load as described in #224. See also: gbaptista/luminous#55 and EFForg/privacybadger#1865.Note that even if this isn't an issue right now, we may experience it once we fix #68.
The text was updated successfully, but these errors were encountered: