Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Read the Docs configuration (automatic) #969

Merged

Conversation

readthedocs-assistant
Copy link
Contributor

Howdy! 馃憢

I am @readthedocs-assistant and I am sending you this pull request to upgrade the configuration of your Read the Docs project.
Your project will continue working whether or not you merge it, but I recommended you take it into consideration.

Also, in case you haven't done it already, remember that you can enable the pull request builds for your project to see the effect of these changes. To do it, follow the instructions, close this pull request, and open it again.

Note: This tool is in beta phase. Don't hesitate to ping @astrojuanlu and/or @humitos if you spot any problems.

The following migrators were applied:

  • Migrate to build.tools configuration.

This uses the new base Docker image based on Ubuntu 20.04 introduced in October 2021
and picks an appropriate Python version for your project
(read our blog post
for details).
Notice that now you can specify the Node.js, Rust, and Go versions as well.

Note: Some system dependencies are not preinstalled anymore,
so this might require manually adding them to build.apt_packages
(see our
documentation
).

  • Migrate to Mamba as a drop-in replacement for Conda.

Your project requested using Mamba instead of Conda for performance reasons.
Now this is included in your configuration
and you can change it without our intervention.

The following migrators were applied:

- Migrate to `build.tools` configuration.

This uses the new base Docker image based on Ubuntu 20.04 introduced in October 2021
and picks an appropriate Python version for your project
(read [our blog post](https://blog.readthedocs.com/new-build-specification/)
for details).
Notice that now you can specify the Node.js, Rust, and Go versions as well.

*Note:* Some system dependencies are not preinstalled anymore,
so this might require manually adding them to `build.apt_packages`
(see [our
documentation](https://docs.readthedocs.io/en/stable/config-file/v2.html#build-apt-packages>)).

- Migrate to Mamba as a drop-in replacement for Conda.

Your project requested using Mamba instead of Conda for performance reasons.
Now this is included in your configuration
and you can change it without our intervention.
@englehardt
Copy link
Collaborator

@vringar From what I can tell we weren't using mamba before, so this seems like a mistake? The other changes look okay as per the blog post.

@astrojuanlu
Copy link

Hi @englehardt ! The last builds of the master branch show that you're using mamba, see for example https://readthedocs.org/projects/openwpm/builds/15787425/

@vringar
Copy link
Contributor

vringar commented Jan 20, 2022

@englehardt I asked the read the docs team to switch us to mamba a while back because conda was using too much memory while resolving dependencies on their runners.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #969 (a7e31af) into master (46131a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   52.27%   52.27%           
=======================================
  Files          34       34           
  Lines        3359     3359           
=======================================
  Hits         1756     1756           
  Misses       1603     1603           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 46131a1...a7e31af. Read the comment docs.

@vringar
Copy link
Contributor

vringar commented Jan 20, 2022

I just allowed the automations for this PR to run so we should see soon if everything works.
Once that is verified I'll merge the PR.

@vringar vringar merged commit 09c1a71 into openwpm:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants