Skip to content

Commit

Permalink
mt76: mt76s: fix oom in mt76s_tx_queue_skb_raw
Browse files Browse the repository at this point in the history
Free the mcu skb in case of error in mt76s_tx_queue_skb_raw routine

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
  • Loading branch information
LorenzoBianconi authored and nbd168 committed Aug 5, 2020
1 parent ae4757a commit c4544d1
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions sdio.c
Expand Up @@ -244,22 +244,27 @@ mt76s_tx_queue_skb_raw(struct mt76_dev *dev, enum mt76_txq_id qid,
struct mt76_queue *q = dev->q_tx[qid].q;
int ret = -ENOSPC, len = skb->len;

spin_lock_bh(&q->lock);
if (q->queued == q->ndesc)
goto out;
goto error;

ret = mt76_skb_adjust_pad(skb);
if (ret)
goto out;
goto error;

spin_lock_bh(&q->lock);

q->entry[q->tail].buf_sz = len;
q->entry[q->tail].skb = skb;
q->tail = (q->tail + 1) % q->ndesc;
q->queued++;

out:
spin_unlock_bh(&q->lock);

return 0;

error:
dev_kfree_skb(skb);

return ret;
}

Expand Down

0 comments on commit c4544d1

Please sign in to comment.