-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Router Discovery broken after ifup lan #135
Comments
dedeckeh
added a commit
that referenced
this issue
Aug 8, 2019
In case setting one of the socket options fails; make sure the raw socket is removed from the uloop file descriptor list before the socket is closed. In case this is not done and a new raw socket is created with the same fd value odhcpd will not be triggered by uloop in case RS messages are received on the socket as reported in #135 Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Fixed in commit https://git.openwrt.org/?p=project/odhcpd.git;a=commit;h=000182fe4f94a5a6ec139456a2b74f0cdea13b9c; thank you for the detailed reporting and reproduction scenario |
aertsk
added a commit
to aertsk/odhcpd
that referenced
this issue
Aug 13, 2019
Make sure the socket is closed in a case where the bridge goes down as a result of NO-CARRIER on the bridge. If not present Router Discovery and Router Advertisement will break permanently after the bridge went down. Related to openwrt#135 Signed-off-by: Koen Aerts <aertskoen5@gmail.com>
aertsk
added a commit
to aertsk/odhcpd
that referenced
this issue
Aug 14, 2019
Make sure the socket is closed in a case where the bridge goes down as a result of NO-CARRIER on the bridge. If not present Router Discovery and Router Advertisement will break permanently after the bridge went down. Related to openwrt#135 Signed-off-by: Koen Aerts <aertskoen5@gmail.com>
aertsk
added a commit
to aertsk/odhcpd
that referenced
this issue
Aug 14, 2019
Make sure the socket is closed in a case where the bridge goes down as a result of NO-CARRIER on the bridge. If not present Router Discovery and Router Advertisement will break permanently after the bridge went down. Related to openwrt#135 Signed-off-by: Koen Aerts <aertskoen5@gmail.com>
aertsk
added a commit
to aertsk/odhcpd
that referenced
this issue
Aug 14, 2019
router: close socket upon NETEV_IFINDEX_CHANGE (squashed) Make sure the socket is closed in a case where the bridge goes down as a result of NO-CARRIER on the bridge. If not present Router Discovery and Router Advertisement will break permanently after the bridge went down. Related to openwrt#135 Signed-off-by: Koen Aerts <aertskoen5@gmail.com>
aertsk
added a commit
to aertsk/odhcpd
that referenced
this issue
Aug 14, 2019
Make sure the socket is closed in a case where the bridge goes down as a result of NO-CARRIER on the bridge. If not present Router Discovery and Router Advertisement will break permanently after the bridge went down. Related to openwrt#135 Signed-off-by: Koen Aerts <aertskoen5@gmail.com>
dedeckeh
pushed a commit
that referenced
this issue
Aug 16, 2019
Make sure the socket is closed in a case where the bridge goes down as a result of NO-CARRIER on the bridge. If not present Router Discovery and Router Advertisement will break permanently after the bridge went down. Related to #135 Signed-off-by: Koen Aerts <aertskoen5@gmail.com>
aertsk
added a commit
to aertsk/odhcpd
that referenced
this issue
Aug 19, 2019
make sure the raw socket is removed from the uloop file descriptor list before the socket is closed. As introduced in openwrt@000182f Related to openwrt#135 Signed-off-by: Koen Aerts <aertskoen5@gmail.com>
aertsk
added a commit
to aertsk/odhcpd
that referenced
this issue
Aug 19, 2019
make sure the raw socket is removed from the uloop file descriptor list before the socket is closed. As introduced in openwrt@000182f Related to openwrt#135 Signed-off-by: Koen Aerts <aertskoen5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Following commit:
c6dae8e#diff-25d902c24283ab8cfbac54dfa101ad31
introduces an issue in odhcpd after 'ifup lan' resulting in the fact that Router Discovery is broken until odhcpd is restarted. Periodic Router Advertisement's are still send out.
Following description describes the reproduction on a TP-Link 1750:
Made use of rdisc6 as part of ndsic6 package (apt install ndisc6) to trigger a Router Solicitation from a host toward the gateway.
host# rdisc6 -1 eth0
REPRODUCTION CONFIG
Used following config on a TP-Link 1750:
Config introduces second bridge 'lan2' as the test bridge next to the existing 'lan' bridge that is used to control the gateway.
Run odhcpd on top of lan2 to handle Router Solicitation/Advertisement
STEPS TO REPRODUCE
STEP 1:
Apply this config, reboot and connect a test host to switch port 3 or 4
STEP 2:
Make sure that Router Solicitation works at this point on lan2
STEP 3:
execute
ifup lan2
on targetSTEP 4:
Trigger another Router Solicitation toward the gateway which should fail at this point
Internally the Recv-Q on the raw socket starts to increase until odhcpd is restarted manually.
RECOVER THE GATEWAY:
The text was updated successfully, but these errors were encountered: