New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.05-rc2] wifi shutdown on TPLINK (ath79 generic) on IRQ 23 not handled #13010
Comments
I don't build myself, so cannot use a patch file. Can you tell me which snapshot contains the fix ? Some instruction how to test would be welcome as well, I only now see that it occurs a while after upgrading. I assume you mean to flip the wifi switch on the back and see if it kills wifi after applying the patch ? |
You can try this file.
Yes. |
Problems meaning: wifi disabling itself during the three days due to the irq |
Is this a sysupgrade based on 23.05-rc2 with just the patch or a snapshot ? (ah, the zip contains a sysupgrade :-) |
Please check whether the button can turn on/off the radio. It's very important since this patch is based on fixing the function of the WiFi switch. |
Ok, so I apply the patch, wait 3 days to see if the IRQ23 triggers (since that is my reported bug) and after that I try if the switch is still functional. I deployed it and I will tell you in a couple of days. [5-7] so far no issues with IRQ23, will test the wifi switch tomorrow. |
Probably unrelated, I get "Unable to execute opkg install command: SyntaxError: Unexpected end of JSON input" whenever I install a package (but it does seem to install without issues). I reflashed because it eventually broke things, but now I dont seem to get the error. |
I tried the wifi switch today, while running nothing changes when I flip the switch, so I hope this is expected behavior. |
Official package source is not compatible with the self-build image, this is the expected behavior. I remember
I made a mistake before, OpenWrt has a local button detection implement. Can you try this new fix? At least now we can confirm that this issue is caused by the WiFi switch. |
I will run the new package 3 days again I assume to see if the IRQ23 is still solved ? After that I will flip the switch to see the difference. After a while (not updating anything) luci throws the unexpected token again (this time in dashboard). Seems like you are right that it is not aligned with a personal build. Anyway, I will run the tests and then return to a safer build again. Luci probably has trouble parsing the output of some command it executes. |
This may be a hardware issue, something like pull-up resistor causing the GPIO to be incorrectly pulled down? I'm not very sure. At the worst, we need to disable the WiFi button. |
I was wondering about that. I never use the wifi switch anyway since shutting down can be done with luci or a script. I would rather have the button disabled to avoid interrupted wifi. I don't see it yet on this build and typically I get it the first few days. I will continue to run it to see if I get a spurious wifi disable. Would it be possible to configure the button action off in the config so a user can choose to disable it when it is causing issues ? The switch is working perfectly, so that part is solved. No errors in the log files, no IRQ23 type of problems, so I think the patch is a go, just wondering why the other spurious issue seems to be solved as well. Maybe me physically flipping it has removed some dust :-) Would this work to disable it (or another suggestion perhaps)
From syslog : It logs this after flipping the switch for both interfaces. It enables them again on the next flip of the switch. |
Disabling WiFi switch will annoy some users. There are still someone needs it.
You can directly delete/rename file I have tried many times, but still cannot reproduce this problem. This issue seems to be caused by The current workaround is to longer the debounce time to 1000 ms. I am unable to confirm whether my theory is correct so I don't want to push it to the mainline. Hope some Archer C7 users can test it more and push it. At lease it seems work for @hhasert
|
Thx, renamed it to |
@hhasert can you help to try this version and show me these outputs. Finally, I would like to check if the registers are correct. You do not need to take the 3-day test(If you are willing, it would be very grateful).
|
On the previous download :
devmem is not installed in that image. I will flash the new one later today and post the results. |
The new release :
Curious why I see the bdata entries for the buttons in this release and not the previous one.... Can I stay on this snapshot or do I need to flash the 23.05-rc2 again and just remove the rfkill button script ?? |
Thanks for letting me know. The register values are correct. I have inserted some debugging code in the latest firmware. If this doesn't bother you, I hope you can continue testing this firmware for a few days. It should no longer have irq23 issue. |
Been following this thread closely, I hope I get around to testing this. |
Hi @Djfe, have you noticed irq23 issue before? |
Kind of. it's far from my daily driver. I'm engaging with Freifunk (Gluon fork) and heard about wifi on these devices sometimes being off. Triggering the switch twice (same position) would turn wifi on again 😅 |
@Djfe Haha, let's just pending this issue and let some developers which have rich knowledge to fix it. It's a hardware/software mixture issue. If we cannot manually trigger it. Debugging will be very difficult. At leaset I have checked the ath79 gpio driver but not find any bugs. P.S. Set bit to P.P.S. A workaround: #13010 (comment) |
So, no more IRQ23 errors detected. Conclusion is correct that the issue is caused by the wifi switch triggering without being touched. I hope you can convince someone to put it in the mainline code. |
Okay, I'll give it a try. Do you want to add a |
Sure, no problem. My name is Hans Hasert. I would rather not publish my email, got enough spam already ;-) |
I'll check eventually if I can find other affected routers. |
I'm encountering the same problem on archer c7 v2:
OpenWrt 22.03.5 r20134-5f15225c1e / LuCI openwrt-22.03 branch git-23.093.57104-ce20b4a Is the fix just to rename the file above?: /etc/rc.button/rfkill EDIT: |
renaming the file should prevent the WiFi going down, but the actual fix is to change the detection of the button timeout which was submitted but still in review because I personally think ' nobody cares' is the correct description in the log. |
Issue is present for me on Archer C7 v2 as well, the renaming as described above seems to work as a workaround so far. However, I also think the proposed patch linked in #13010 (comment) should be reviewed / merged as a proper fix |
Due to circuit issue or silicon defect, sometimes the WiFi switch button of the Archer C7 v2 can be accidentally triggered multiple times in one second. This will cause WiFi to be unexpectedly shut down and trigger 'irq 23: nobody cared'[1] warning. Increasing the key debounce interval to 1000 ms can fix this issue. This patch also add the missing rfkill key label. [1] Warning Log: ``` [87765.218511] irq 23: nobody cared (try booting with the "irqpoll" option) [87765.225331] CPU: 0 PID: 317 Comm: irq/23-keys Not tainted 5.15.118 #0 ... [87765.486246] handlers: [87765.488543] [<85257547>] 0x800c29a0 threaded [<5c6328a2>] 0x80ffe0b8 [gpio_button_hotplug@4cf73d00+0x1a00] [87765.498364] Disabling IRQ #23 ``` Fixes: #13010 Fixes: #12167 Fixes: #11191 Fixes: #7835 Tested-by: Hans Hasert Signed-off-by: Shiji Yang <yangshiji66@qq.com> (cherry picked from commit e32f70e)
Due to circuit issue or silicon defect, sometimes the WiFi switch button of the Archer C7 v2 can be accidentally triggered multiple times in one second. This will cause WiFi to be unexpectedly shut down and trigger 'irq 23: nobody cared'[1] warning. Increasing the key debounce interval to 1000 ms can fix this issue. This patch also add the missing rfkill key label. [1] Warning Log: ``` [87765.218511] irq 23: nobody cared (try booting with the "irqpoll" option) [87765.225331] CPU: 0 PID: 317 Comm: irq/23-keys Not tainted 5.15.118 #0 ... [87765.486246] handlers: [87765.488543] [<85257547>] 0x800c29a0 threaded [<5c6328a2>] 0x80ffe0b8 [gpio_button_hotplug@4cf73d00+0x1a00] [87765.498364] Disabling IRQ openwrt#23 ``` Fixes: openwrt#13010 Fixes: openwrt#12167 Fixes: openwrt#11191 Fixes: openwrt#7835 Tested-by: Hans Hasert Signed-off-by: Shiji Yang <yangshiji66@qq.com>
Due to circuit issue or silicon defect, sometimes the WiFi switch button of the Archer C7 v2 can be accidentally triggered multiple times in one second. This will cause WiFi to be unexpectedly shut down and trigger 'irq 23: nobody cared'[1] warning. Increasing the key debounce interval to 1000 ms can fix this issue. This patch also add the missing rfkill key label. [1] Warning Log: ``` [87765.218511] irq 23: nobody cared (try booting with the "irqpoll" option) [87765.225331] CPU: 0 PID: 317 Comm: irq/23-keys Not tainted 5.15.118 #0 ... [87765.486246] handlers: [87765.488543] [<85257547>] 0x800c29a0 threaded [<5c6328a2>] 0x80ffe0b8 [gpio_button_hotplug@4cf73d00+0x1a00] [87765.498364] Disabling IRQ #23 ``` Fixes: #13010 Fixes: #12167 Fixes: #11191 Fixes: #7835 Tested-by: Hans Hasert Signed-off-by: Shiji Yang <yangshiji66@qq.com> (cherry picked from commit e32f70e)
Due to circuit issue or silicon defect, sometimes the WiFi switch button of the Archer C7 v2 can be accidentally triggered multiple times in one second. This will cause WiFi to be unexpectedly shut down and trigger 'irq 23: nobody cared'[1] warning. Increasing the key debounce interval to 1000 ms can fix this issue. This patch also add the missing rfkill key label. [1] Warning Log: ``` [87765.218511] irq 23: nobody cared (try booting with the "irqpoll" option) [87765.225331] CPU: 0 PID: 317 Comm: irq/23-keys Not tainted 5.15.118 #0 ... [87765.486246] handlers: [87765.488543] [<85257547>] 0x800c29a0 threaded [<5c6328a2>] 0x80ffe0b8 [gpio_button_hotplug@4cf73d00+0x1a00] [87765.498364] Disabling IRQ openwrt#23 ``` Fixes: openwrt#13010 Fixes: openwrt#12167 Fixes: openwrt#11191 Fixes: openwrt#7835 Tested-by: Hans Hasert Signed-off-by: Shiji Yang <yangshiji66@qq.com>
Due to circuit issue or silicon defect, sometimes the WiFi switch button of the Archer C7 v2 can be accidentally triggered multiple times in one second. This will cause WiFi to be unexpectedly shut down and trigger 'irq 23: nobody cared'[1] warning. Increasing the key debounce interval to 1000 ms can fix this issue. This patch also add the missing rfkill key label. [1] Warning Log: ``` [87765.218511] irq 23: nobody cared (try booting with the "irqpoll" option) [87765.225331] CPU: 0 PID: 317 Comm: irq/23-keys Not tainted 5.15.118 #0 ... [87765.486246] handlers: [87765.488543] [<85257547>] 0x800c29a0 threaded [<5c6328a2>] 0x80ffe0b8 [gpio_button_hotplug@4cf73d00+0x1a00] [87765.498364] Disabling IRQ openwrt#23 ``` Fixes: openwrt#13010 Fixes: openwrt#12167 Fixes: openwrt#11191 Fixes: openwrt#7835 Tested-by: Hans Hasert Signed-off-by: Shiji Yang <yangshiji66@qq.com>
Due to circuit issue or silicon defect, sometimes the WiFi switch button of the Archer C7 v2 can be accidentally triggered multiple times in one second. This will cause WiFi to be unexpectedly shut down and trigger 'irq 23: nobody cared'[1] warning. Increasing the key debounce interval to 1000 ms can fix this issue. This patch also add the missing rfkill key label. [1] Warning Log: ``` [87765.218511] irq 23: nobody cared (try booting with the "irqpoll" option) [87765.225331] CPU: 0 PID: 317 Comm: irq/23-keys Not tainted 5.15.118 #0 ... [87765.486246] handlers: [87765.488543] [<85257547>] 0x800c29a0 threaded [<5c6328a2>] 0x80ffe0b8 [gpio_button_hotplug@4cf73d00+0x1a00] [87765.498364] Disabling IRQ #23 ``` Fixes: openwrt/openwrt#13010 Fixes: openwrt/openwrt#12167 Fixes: openwrt/openwrt#11191 Fixes: openwrt/openwrt#7835 Tested-by: Hans Hasert Signed-off-by: Shiji Yang <yangshiji66@qq.com>
Describe the bug
The same happened on previous releases, the IRQ23 was not handled, but before it was just a kernel log message and nobody cared, but in this release (I think related to 5.15 kernel since I had it on snapshots before) when it happens it shuts down all wifi which ia a bad thing in a teams call ;-)
OpenWrt version
r23228-cd17d8df2a
OpenWrt target/subtarget
ath79/generic
Device
TP-Link Archer C7 v2
Image kind
Official downloaded image
Steps to reproduce
Just wait for it to happen (took mine less than a day)
Actual behaviour
The wifi just shuts down and in the kernel log you see :
[87765.218511] irq 23: nobody cared (try booting with the "irqpoll" option)
[87765.225331] CPU: 0 PID: 317 Comm: irq/23-keys Not tainted 5.15.118 #0
[87765.231874] Stack : 00000000 00000004 00000000 00000000 00000000 00000000 00000000 00000000
[87765.240373] 00000000 00000000 00000000 00000000 00000000 00000001 80c0b92 d1e8e1bf
[87765.248874] 80c0b9b8 00000000 00000000 80c0b7c0 00000038 8032d404 00000000 ffffffea
[87765.257375] 00000181 80c0b7cc 00000181 80720078 80660820 80c0b900 00000017 807846e0
[87765.265876] 0000001f 80790b68 80784480 80780000 00000018 80399288 00000000 808d0000
[87765.274377] ...
[87765.276859] Call Trace:
[87765.276870] [<8032d404>] 0x8032d404
[87765.282891] [<80399288>] 0x80399288
[87765.286469] [<800665b4>] 0x800665b4
[87765.290008] [<800665bc>] 0x800665bc
[87765.293545] [<800c51e8>] 0x800c51e8
[87765.297084] [<800c5704>] 0x800c5704
[87765.300619] [<8032da34>] 0x8032da34
[87765.304159] [<800c2970>] 0x800c2970
[87765.307695] [<800c5de4>] 0x800c5de4
[87765.311231] [<8032da34>] 0x8032da34
[87765.314770] [<800c5de4>] 0x800c5de4
[87765.318308] [<800c2034>] 0x800c2034
[87765.321846] [<80346cd8>] 0x80346cd8
[87765.325383] [<800c2970>] 0x800c2970
[87765.328921] [<800c2034>] 0x800c2034
[87765.332459] [<800c2970>] 0x800c2970
[87765.335995] [<8032da34>] 0x8032da34
[87765.339536] [<800c1ff0>] 0x800c1ff0
[87765.343071] [<8064c184>] 0x8064c184
[87765.346608] [<800c2034>] 0x800c2034
[87765.350146] [<8032d6d8>] 0x8032d6d8
[87765.353683] [<8032da34>] 0x8032da34
[87765.357230] [<80062198>] 0x80062198
[87765.360768] [<800c1ff0>] 0x800c1ff0
[87765.364304] [<8032da34>] 0x8032da34
[87765.367842] [<80346cd8>] 0x80346cd8
[87765.371380] [<8064c184>] 0x8064c184
[87765.374938] [<80511c48>] 0x80511c48
[87765.378476] [<8061a168>] 0x8061a168
[87765.382010] [<8032d42c>] 0x8032d42c
[87765.385549] [<8063a0fc>] 0x8063a0fc
[87765.389093] [<80511c48>] 0x80511c48
[87765.392644] [<8046e13c>] 0x8046e13c
[87765.396188] [<8046d9f8>] 0x8046d9f8
[87765.399724] [<80511c48>] 0x80511c48
[87765.403276] [<8046e530>] 0x8046e530
[87765.406822] [<80511c48>] 0x80511c48
[87765.410373] [<805108fc>] 0x805108fc
[87765.413913] [<80511b34>] 0x80511b34
[87765.417452] [<8050b9f4>] 0x8050b9f4
[87765.420997] [<8050c55c>] 0x8050c55c
[87765.424533] [<8050c6a4>] 0x8050c6a4
[87765.428076] [<8050bf7c>] 0x8050bf7c
[87765.431622] [<8050ce54>] 0x8050ce54
[87765.435166] [<80470484>] 0x80470484
[87765.438710] [<8006c578>] 0x8006c578
[87765.442249] [<804706cc>] 0x804706cc
[87765.445793] [<80413100>] 0x80413100
[87765.449337] [<80470d14>] 0x80470d14
[87765.452880] [<80471060>] 0x80471060
[87765.456416] [<8047126c>] 0x8047126c
[87765.459952] [<800c0000>] 0x800c0000
[87765.463492] [<8064c2f4>] 0x8064c2f4
[87765.467028] [<800c71dc>] 0x800c71dc
[87765.470568] [<800c0000>] 0x800c0000
[87765.474112] [<8032d6d8>] 0x8032d6d8
[87765.477656] [<800c3244>] 0x800c3244
[87765.481195] [<80062198>] 0x80062198
[87765.484737]
[87765.486246] handlers:
[87765.488543] [<85257547>] 0x800c29a0 threaded [<5c6328a2>] 0x80ffe0b8 [gpio_button_hotplug@4cf73d00+0x1a00]
[87765.498364] Disabling IRQ #23
Expected behaviour
I don't care about irq23 and nobody does it says, but I don't want Wifi to shut down, very annoying in a teams call.
Additional info
It did this on 22.03.5 but then it did not shutdown wifi, I noticed this earlier on snapshot releases using kernel 5.15.
Diffconfig
No response
Terms
The text was updated successfully, but these errors were encountered: