Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPQ8074: Zyxel NBG7815: "kernel: backport nvmem v6.6 fixes and v6.7 changes" patch causing random MAC on each boot #13831

Closed
1 task done
pwned-pixel opened this issue Oct 30, 2023 · 11 comments
Closed
1 task done

IPQ8074: Zyxel NBG7815: "kernel: backport nvmem v6.6 fixes and v6.7 changes" patch causing random MAC on each boot #13831

pwned-pixel opened this issue Oct 30, 2023 · 11 comments
Labels
bug issue report with a confirmed bug

Comments

@pwned-pixel
Copy link
Contributor

pwned-pixel commented Oct 30, 2023 •
edited
Loading

Describe the bug

After applying this commit:

b595670
kernel: backport nvmem v6.6 fixes and v6.7 changes

the MAC addresses are changing on every reboot on this device.

[ 4.171248] GMAC2(ffffff8003ffxxxx) Invalid MAC@ - using 82:3f:e0:52:de:8b
[ 4.174842] GMAC3(ffffff8003c8xxxx) Invalid MAC@ - using 16:86:7f:39:0c:1d
[ 4.181661] GMAC4(ffffff8003ffxxxx) Invalid MAC@ - using 1e:b9:7f:62:e1:3d
[ 4.188461] GMAC5(ffffff8003d7xxxx) Invalid MAC@ - using f2:f6:f7:59:51:28
[ 4.395754] GMAC6(ffffff8004d9xxxx) Invalid MAC@ - using 86:a2:36:58:1e:65

This kernel message is not present on earlier versions. I've tracked it down to this commit. If you need the whole dmesg just let me know.

OpenWrt version

r24256-1d6f9bdfc0

OpenWrt target/subtarget

qualcommax/ipq807x

Device

Zyxel NBG7815

Image kind

Self-built image

Steps to reproduce

No response

Actual behaviour

No response

Expected behaviour

MAC's should be stable on each boot.

Additional info

No response

Diffconfig

CONFIG_TARGET_qualcommax=y
CONFIG_TARGET_qualcommax_ipq807x=y
CONFIG_TARGET_MULTI_PROFILE=y
CONFIG_TARGET_DEVICE_qualcommax_ipq807x_DEVICE_xiaomi_ax3600=y
CONFIG_TARGET_DEVICE_PACKAGES_qualcommax_ipq807x_DEVICE_xiaomi_ax3600=""
CONFIG_TARGET_DEVICE_qualcommax_ipq807x_DEVICE_zyxel_nbg7815=y
CONFIG_TARGET_DEVICE_PACKAGES_qualcommax_ipq807x_DEVICE_zyxel_nbg7815=""
CONFIG_TARGET_PER_DEVICE_ROOTFS=y

Terms

  • I am reporting an issue for OpenWrt, not an unsupported fork.
@pwned-pixel pwned-pixel added the bug issue report with a confirmed bug label Oct 30, 2023
@pwned-pixel
Copy link
Contributor Author

I've tried to start narrowing things down and I've just deleted 816-v6.7-0004-Revert-nvmem-add-new-config-option.patch. It is fixing the issue. But I don't know if and what sideeffects this could introduce.

@robimarko
Copy link
Contributor

@rmilecki

@john-tho
Copy link
Contributor

Nice work narrowing this down. Rafal will fix, but if you wanted to keep digging in the meantime, could you check if there are any message from the u-boot,env driver in dmesg (like: Failed to get)?
This line in u_boot_env_probe looks suspicious

	priv->mtd = of_get_mtd_device_by_node(np);
	if (IS_ERR(priv->mtd)) {
		dev_err_probe(dev, PTR_ERR(priv->mtd), "Failed to get %pOF MTD\n", np);
		return PTR_ERR(priv->mtd);
	}

given we are modifying the of_node

openwrt/target/linux/generic/backport-6.1/816-v6.7-0004-Revert-nvmem-add-new-config-option.patch

Lines 50 to 58 in b595670

+++ b/drivers/nvmem/core.c
@@ -936,7 +936,7 @@ struct nvmem_device *nvmem_register(cons
nvmem->nkeepout = config->nkeepout;
if (config->of_node)
nvmem->dev.of_node = config->of_node;
- else if (!config->no_of_node)
+ else
nvmem->dev.of_node = config->dev->of_node;

If you cannot find anything in dmesg, would you be able to check the DT node u-boot,env is using in u_boot_env_probe with and without the breaking change? Could edit this file inplace under openwrt/build_dir/target-aarch_*/linux-*/linux-6*, then make target/linux/install, but only if easy to recover from a bad flash, as easy to make mistakes this way.

--- drivers/nvmem/u-boot-env.c.orig	2023-10-31 06:44:36.186727737 +1000
+++ drivers/nvmem/u-boot-env.c	2023-10-31 06:47:18.392136608 +1000
@@ -211,6 +211,7 @@
 	struct u_boot_env *priv;
 	int err;
 
+	dev_warn(dev, "DT node: %pOF\n", np);
 	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;

Cheers

@rmilecki
Copy link
Contributor

I'll try to debug that tomorrow. I got some idea (posted comment actually) about add_legacy_fixed_of_cells but that was incorrect. I've to spend some extra time on it.

@pwned-pixel
Copy link
Contributor Author

pwned-pixel commented Oct 31, 2023 •
edited
Loading

could you check if there are any message from the u-boot,env driver in dmesg (like: Failed to get)?

I've checked. There is no such message. I've attached: dmesg (failed state), z-loader, u-boot and pre-boot log:

dmesg.txt
uboot.txt
zloader.txt
pre-boot.txt

If you cannot find anything in dmesg, would you be able to check the DT node u-boot,env is using in u_boot_env_probe with and without the breaking change? Could edit this file inplace under openwrt/build_dir/target-aarch_/linux-/linux-6*, then make target/linux/install, but only if easy to recover from a bad flash, as easy to make mistakes this way.

I'll try it. But probably not until evening.

EDIT:

with full patch set

[ 1.045549] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: DT node: /soc/spi@78b5000/flash@0/partitions/partition@600000

with deleted 816-v6.7-0004-Revert-nvmem-add-new-config-option.patch

[ 1.045321] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: DT node: /soc/spi@78b5000/flash@0/partitions/partition@600000

So no change (beside the invalid MAC lines).

@rmilecki
Copy link
Contributor

rmilecki commented Oct 31, 2023 •
edited
Loading

Can you please compile and run firmware with my debugging patch "kernel: add nvmem u-boot-env debugging patch for 6.1"? I pushed branch with it to the https://git.openwrt.org/?p=openwrt/staging/rmilecki.git;a=shortlog;h=refs/heads/nvmem-u-boot-env-debugging

I can't figure out this issue. NVMEM driver for U-Boot env works on my bcm4908 device. I can't understand how this change can break anything.

@pwned-pixel
Copy link
Contributor Author

Sure, I'm currently building and I will give feedback as soon as I can. It could be that it will be delayed after lunch.

@pwned-pixel
Copy link
Contributor Author

pwned-pixel commented Oct 31, 2023 •
edited by rmilecki
Loading 

Starting kernel ...

Jumping to AARCH64 kernel via monitor
[    0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034]
[    0.000000] Linux version 6.1.60 () (aarch64-openwrt-linux-musl-gcc (OpenWrt GCC 12.3.0 r24256-1d6f9bdfc0) 12.3.0, GNU ld (GNU Binutils) 2.40.0) #0 SMP Mon Oct 30 08:08:39 2023
[    0.000000] Machine model: Zyxel NBG7815
[    0.000000] Zone ranges:
[    0.000000]   DMA      [mem 0x0000000040000000-0x000000007fffffff]
[    0.000000]   DMA32    empty
[    0.000000]   Normal   empty
[    0.000000] Movable zone start for each node
[    0.000000] Early memory node ranges
[    0.000000]   node   0: [mem 0x0000000040000000-0x0000000040ffffff]
[    0.000000]   node   0: [mem 0x0000000041000000-0x000000004a3fffff]
[    0.000000]   node   0: [mem 0x000000004a400000-0x00000000510fffff]
[    0.000000]   node   0: [mem 0x0000000051100000-0x000000007fffffff]
[    0.000000] Initmem setup node 0 [mem 0x0000000040000000-0x000000007fffffff]
[    0.000000] psci: probing for conduit method from DT.
[    0.000000] psci: PSCIv1.0 detected in firmware.
[    0.000000] psci: Using standard PSCI v0.2 function IDs
[    0.000000] psci: MIGRATE_INFO_TYPE not supported.
[    0.000000] psci: SMC Calling Convention v1.0
[    0.000000] psci: OSI mode supported.
[    0.000000] psci: failed to set PC mode: -1
[    0.000000] percpu: Embedded 17 pages/cpu s31080 r8192 d30360 u69632
[    0.000000] Detected VIPT I-cache on CPU0
[    0.000000] alternatives: applying boot alternatives
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 258048
[    0.000000] Kernel command line: console=ttyMSM0,115200n8 root=PARTUUID=a0bb3852-36cc-ac69-a1a2-6bd39ff56f0a rootwait
[    0.000000] Dentry cache hash table entries: 131072 (order: 8, 1048576 bytes, linear)
[    0.000000] Inode-cache hash table entries: 65536 (order: 7, 524288 bytes, linear)
[    0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off
[    0.000000] Memory: 887724K/1048576K available (7744K kernel code, 854K rwdata, 2268K rodata, 1280K init, 273K bss, 160852K reserved, 0K cma-reserved)
[    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1
[    0.000000] rcu: Hierarchical RCU implementation.
[    0.000000] 	Tracing variant of Tasks RCU enabled.
[    0.000000] rcu: RCU calculated value of scheduler-enlistment delay is 10 jiffies.
[    0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0
[    0.000000] Root IRQ handler: gic_handle_irq
[    0.000000] GICv2m: range[mem 0x0b00a000-0x0b00affc], SPI[448:479]
[    0.000000] rcu: srcu_init: Setting srcu_struct sizes based on contention.
[    0.000000] arch_timer: cp15 and mmio timer(s) running at 19.20MHz (virt/virt).
[    0.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0x46d987e47, max_idle_ns: 440795202767 ns
[    0.000001] sched_clock: 56 bits at 19MHz, resolution 52ns, wraps every 4398046511078ns
[    0.000102] Calibrating delay loop (skipped), value calculated using timer frequency.. 38.40 BogoMIPS (lpj=192000)
[    0.000116] pid_max: default: 32768 minimum: 301
[    0.000592] Mount-cache hash table entries: 2048 (order: 2, 16384 bytes, linear)
[    0.000606] Mountpoint-cache hash table entries: 2048 (order: 2, 16384 bytes, linear)
[    0.002453] cblist_init_generic: Setting adjustable number of callback queues.
[    0.002462] cblist_init_generic: Setting shift to 2 and lim to 1.
[    0.002657] rcu: Hierarchical SRCU implementation.
[    0.002661] rcu: 	Max phase no-delay instances is 1000.
[    0.003478] smp: Bringing up secondary CPUs ...
[    0.004122] Detected VIPT I-cache on CPU1
[    0.004266] CPU1: Booted secondary processor 0x0000000001 [0x410fd034]
[    0.004940] Detected VIPT I-cache on CPU2
[    0.005043] CPU2: Booted secondary processor 0x0000000002 [0x410fd034]
[    0.005668] Detected VIPT I-cache on CPU3
[    0.005770] CPU3: Booted secondary processor 0x0000000003 [0x410fd034]
[    0.005838] smp: Brought up 1 node, 4 CPUs
[    0.005846] SMP: Total of 4 processors activated.
[    0.005851] CPU features: detected: 32-bit EL0 Support
[    0.005855] CPU features: detected: CRC32 instructions
[    0.005918] CPU features: emulated: Privileged Access Never (PAN) using TTBR0_EL1 switching
[    0.005925] CPU: All CPU(s) started at EL1
[    0.005927] alternatives: applying system-wide alternatives
[    0.016833] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns
[    0.016861] futex hash table entries: 1024 (order: 4, 65536 bytes, linear)
[    0.017092] pinctrl core: initialized pinctrl subsystem
[    0.018258] NET: Registered PF_NETLINK/PF_ROUTE protocol family
[    0.018805] DMA: preallocated 128 KiB GFP_KERNEL pool for atomic allocations
[    0.018850] DMA: preallocated 128 KiB GFP_KERNEL|GFP_DMA pool for atomic allocations
[    0.018885] DMA: preallocated 128 KiB GFP_KERNEL|GFP_DMA32 pool for atomic allocations
[    0.019294] thermal_sys: Registered thermal governor 'step_wise'
[    0.019490] cpuidle: using governor menu
[    0.019759] ASID allocator initialised with 65536 entries
[    0.074551] qcom,cpr4-apss-regulator b018000.cpr4-ctrl: CPR valid fuse count: 4
[    0.083154] SCSI subsystem initialized
[    0.083343] usbcore: registered new interface driver usbfs
[    0.083396] usbcore: registered new interface driver hub
[    0.083442] usbcore: registered new device driver usb
[    0.083886] qcom_scm: convention: smc arm 64
[    0.085217] clocksource: Switched to clocksource arch_sys_counter
[    0.086357] NET: Registered PF_INET protocol family
[    0.086513] IP idents hash table entries: 16384 (order: 5, 131072 bytes, linear)
[    0.087855] tcp_listen_portaddr_hash hash table entries: 512 (order: 1, 8192 bytes, linear)
[    0.087879] Table-perturb hash table entries: 65536 (order: 6, 262144 bytes, linear)
[    0.087893] TCP established hash table entries: 8192 (order: 4, 65536 bytes, linear)
[    0.087982] TCP bind hash table entries: 8192 (order: 6, 262144 bytes, linear)
[    0.088264] TCP: Hash tables configured (established 8192 bind 8192)
[    0.088366] UDP hash table entries: 512 (order: 2, 16384 bytes, linear)
[    0.088404] UDP-Lite hash table entries: 512 (order: 2, 16384 bytes, linear)
[    0.088611] NET: Registered PF_UNIX/PF_LOCAL protocol family
[    0.088648] PCI: CLS 0 bytes, default 64
[    0.089949] workingset: timestamp_bits=46 max_order=18 bucket_order=0
[    0.095021] squashfs: version 4.0 (2009/01/31) Phillip Lougher
[    0.095035] jffs2: version 2.2 (NAND) (SUMMARY) (LZMA) (RTIME) (CMODE_PRIORITY) (c) 2001-2006 Red Hat, Inc.
[    0.098180] qcom-qmp-usb-phy 58000.phy: supply vdda-phy not found, using dummy regulator
[    0.098355] qcom-qmp-usb-phy 58000.phy: supply vdda-pll not found, using dummy regulator
[    0.099790] qcom-qmp-usb-phy 78000.phy: supply vdda-phy not found, using dummy regulator
[    0.099965] qcom-qmp-usb-phy 78000.phy: supply vdda-pll not found, using dummy regulator
[    0.101681] qcom-qusb2-phy 59000.phy: supply vdd not found, using dummy regulator
[    0.101818] qcom-qusb2-phy 59000.phy: supply vdda-pll not found, using dummy regulator
[    0.101858] qcom-qusb2-phy 59000.phy: supply vdda-phy-dpdm not found, using dummy regulator
[    0.102020] qcom-qusb2-phy 59000.phy: Registered Qcom-QUSB2 phy
[    0.102233] qcom-qusb2-phy 79000.phy: supply vdd not found, using dummy regulator
[    0.102377] qcom-qusb2-phy 79000.phy: supply vdda-pll not found, using dummy regulator
[    0.102461] qcom-qusb2-phy 79000.phy: supply vdda-phy-dpdm not found, using dummy regulator
[    0.102604] qcom-qusb2-phy 79000.phy: Registered Qcom-QUSB2 phy
[    0.107501] bam-dma-engine 704000.dma-controller: num-channels unspecified in dt
[    0.107517] bam-dma-engine 704000.dma-controller: num-ees unspecified in dt
[    0.112228] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled
[    0.112957] msm_serial 78b1000.serial: msm_serial: detected port #1
[    0.112995] msm_serial 78b1000.serial: uartclk = 19200000
[    0.113094] 78b1000.serial: ttyMSM1 at MMIO 0x78b1000 (irq = 20, base_baud = 1200000) is a MSM
[    0.113534] msm_serial 78b3000.serial: msm_serial: detected port #0
[    0.113563] msm_serial 78b3000.serial: uartclk = 3686400
[    0.113643] 78b3000.serial: ttyMSM0 at MMIO 0x78b3000 (irq = 21, base_baud = 230400) is a MSM
[    0.113668] msm_serial: console setup on port #0
[    0.842048] printk: console [ttyMSM0] enabled
[    0.847207] msm_serial: driver initialized
[    0.856120] loop: module loaded
[    0.857311] spi_qup 78b5000.spi: IN:block:16, fifo:64, OUT:block:16, fifo:64
[    0.859055] spi-nor spi0.0: w25q64dw (8192 Kbytes)
[    0.865676] 22 fixed-partitions partitions found on MTD device spi0.0
[    0.870314] Creating 22 MTD partitions on "spi0.0":
[    0.876512] 0x000000000000-0x000000050000 : "0:sbl1"
[    0.881719] 0x000000050000-0x000000060000 : "0:mibib"
[    0.886873] 0x000000060000-0x000000080000 : "0:bootconfig"
[    0.891793] 0x000000080000-0x0000000a0000 : "0:bootconfig1"
[    0.897223] 0x0000000a0000-0x000000220000 : "0:qsee"
[    0.902633] 0x000000220000-0x0000003a0000 : "0:qsee_1"
[    0.907946] 0x0000003a0000-0x0000003b0000 : "0:devcfg"
[    0.912807] 0x0000003b0000-0x0000003c0000 : "0:devcfg_1"
[    0.917934] 0x0000003c0000-0x0000003d0000 : "0:apdp"
[    0.923393] 0x0000003d0000-0x0000003e0000 : "0:apdp_1"
[    0.928335] 0x0000003e0000-0x000000420000 : "0:rpm"
[    0.933291] 0x000000420000-0x000000460000 : "0:rpm_1"
[    0.938128] 0x000000460000-0x000000470000 : "0:cdt"
[    0.943251] 0x000000470000-0x000000480000 : "0:cdt_1"
[    0.947988] 0x000000480000-0x000000540000 : "0:appsbl"
[    0.953175] 0x000000540000-0x000000600000 : "0:appsbl_1"
[    0.958229] 0x000000600000-0x000000610000 : "0:appsblenv"
[    0.963655] 0x000000610000-0x000000650000 : "0:art"
[    0.969016] 0x000000650000-0x0000006d0000 : "0:ethphyfw"
[    0.973661] 0x0000006d0000-0x0000006e0000 : "0:crt"
[    0.979292] 0x0000006e0000-0x0000006f0000 : "dual_flag"
[    0.983764] 0x0000006f0000-0x000000800000 : "reserved"
[    0.997186] spmi spmi-0: PMIC arbiter version v2 (0x20010000)
[    1.020341] i2c_dev: i2c /dev entries driver
[    1.027930] sdhci: Secure Digital Host Controller Interface driver
[    1.027978] sdhci: Copyright(c) Pierre Ossman
[    1.033013] sdhci-pltfm: SDHCI platform and OF driver helper
[    1.039477] remoteproc remoteproc0: releasing cd00000.q6v5_wcss
[    1.045542] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_probe] np:/soc/spi@78b5000/flash@0/partitions/partition@600000
[    1.063555] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] dev->of_node:/soc/spi@78b5000/flash@0/partitions/partition@600000
[    1.063631] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found 34 cells
[    1.077019] mmc0: SDHCI controller on 7824900.mmc [7824900.mmc] using ADMA 64-bit
[    1.086824] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:baudrate np:(null)
[    1.094270] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:bootargs np:(null)
[    1.105916] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:bootcmd np:(null)
[    1.117541] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:bootdelay np:(null)
[    1.129172] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:boxid np:(null)
[    1.131825] mmc0: new HS200 MMC card at address 0001
[    1.140716] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:countrycode np:(null)
[    1.140727] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:defenv np:(null)
[    1.152801] mmcblk0: mmc0:0001 M62704 3.53 GiB 
[    1.157212] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ethact np:(null)
[    1.157224] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ethaddr np:/soc/spi@78b5000/flash@0/partitions/partition@600000/ethaddr
[    1.170658]  mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11
[    1.180287] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:fdt_high np:(null)
[    1.186464] mmcblk0boot0: mmc0:0001 M62704 2.00 MiB 
[    1.196287] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:fdtcontroladdr np:(null)
[    1.196301] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:flash_type np:(null)
[    1.213389] mmcblk0boot1: mmc0:0001 M62704 2.00 MiB 
[    1.218065] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:fwimg np:(null)
[    1.230049] mmcblk0rpmb: mmc0:0001 M62704 512 KiB, chardev (247:0)
[    1.234636] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ipaddr np:(null)
[    1.280908] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ledB np:(null)
[    1.292280] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ledG np:(null)
[    1.303768] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ledR np:(null)
[    1.315023] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ledRblink np:(null)
[    1.326308] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ledallon np:(null)
[    1.337940] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:ledinit np:(null)
[    1.349658] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:machid np:(null)
[    1.361290] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:netmask np:(null)
[    1.372489] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:partno np:(null)
[    1.384293] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:preboot np:(null)
[    1.395492] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:progimg np:(null)
[    1.407297] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:progzyxelimg np:(null)
[    1.418843] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:serialnum np:(null)
[    1.430735] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:serverip np:(null)
[    1.442367] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:soc_version_major np:(null)
[    1.454087] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:soc_version_minor np:(null)
[    1.466413] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:stderr np:(null)
[    1.478825] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:stdin np:(null)
[    1.490207] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:stdout np:(null)
[    1.501655] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_add_cells] Found cell name:readonly np:(null)
[    1.513029] u_boot_env 78b5000.spi:flash@0:partitions:partition@600000: [u_boot_env_probe] u_boot_env_parse():0
[    1.526388] NET: Registered PF_INET6 protocol family
[    1.536123] Segment Routing with IPv6
[    1.539949] In-situ OAM (IOAM) with IPv6
[    1.543537] NET: Registered PF_PACKET protocol family
[    1.547521] 8021q: 802.1Q VLAN Support v1.8
[    1.574009] qcom,cpr4-apss-regulator b018000.cpr4-ctrl: CPR valid fuse count: 4
[    1.574346] cpr4_ipq807x_apss_read_fuse_data: apc_corner: speed bin = 0
[    1.580161] cpr4_ipq807x_apss_read_fuse_data: apc_corner: CPR fusing revision = 1
[    1.586745] cpr4_ipq807x_apss_read_fuse_data: apc_corner: CPR misc fuse value = 0
[    1.594396] cpr4_ipq807x_apss_read_fuse_data: apc_corner: Voltage boost fuse config = 0 boost = disable
[    1.601910] cpr3_mem_acc_init: apc: not using memory accelerator regulator
[    1.611047] cpr4_ipq807x_apss_calculate_open_loop_voltages: apc_corner: fused      SVS: open-loop= 712000 uV
[    1.617994] cpr4_ipq807x_apss_calculate_open_loop_voltages: apc_corner: fused      NOM: open-loop= 832000 uV
[    1.627982] cpr4_ipq807x_apss_calculate_open_loop_voltages: apc_corner: fused    TURBO: open-loop= 904000 uV
[    1.637786] cpr4_ipq807x_apss_calculate_open_loop_voltages: apc_corner: fused   STURBO: open-loop= 992000 uV
[    1.647646] cpr4_ipq807x_apss_calculate_target_quotients: apc_corner: fused      SVS: quot[ 7]= 701, quot_offset[ 7]=   0
[    1.657406] cpr4_ipq807x_apss_calculate_target_quotients: apc_corner: fused      NOM: quot[ 7]= 925, quot_offset[ 7]= 220
[    1.668257] cpr4_ipq807x_apss_calculate_target_quotients: apc_corner: fused    TURBO: quot[ 7]=1045, quot_offset[ 7]= 120
[    1.679194] cpr4_ipq807x_apss_calculate_target_quotients: apc_corner: fused   STURBO: quot[ 7]=1198, quot_offset[ 7]= 150
[    1.690347] cpr3_regulator_init_ctrl: apc: Default CPR mode = closed-loop
[    1.693464] cpufreq: cpufreq_online: CPU0: Running at unlisted initial frequency: 800000 KHz, changing to: 1017600 KHz
�[    1.721258] VFS: Mounted root (squashfs filesystem) readonly on device 179:8.
[    1.721681] Freeing unused kernel memory: 1280K
[    1.785354] Run /sbin/init as init process
[    1.893239] init: Console is alive
[    1.893381] init: - watchdog -
[    2.229635] kmodloader: loading kernel modules from /etc/modules-boot.d/*
[    2.240148] hwmon hwmon0: temp1_input not attached to any thermal zone
[    2.347659] malibu_phy_api_ops_init[2854]:INFO:qca probe malibu phy driver succeeded!
[    2.351522] aquantia_phy_api_ops_init[2244]:INFO:qca probe aquantia phy driver succeeded!
[    2.355102] qca808x_phy_api_ops_init[2665]:INFO:qca probe qca808x phy driver succeeded!
[    4.025305] regi_init[3989]:INFO:Initializing HPPE Done!!
[    4.025478] regi_init[4049]:INFO:qca-ssdk module init succeeded!
[    4.032096] EDMA ver 1 hw init
[    4.036005] EDMA HW Reset completed succesfully
[    4.038658] Num rings - TxDesc:1 (23-23) TxCmpl:1 (7-7)
[    4.043054] RxDesc:1 (15-15) RxFill:1 (7-7)
[    4.050343] GMAC2(ffffff80035axxxx) Invalid MAC@ - using 52:67:90:02:b8:ff
[    4.053533] GMAC3(ffffff80040cxxxx) Invalid MAC@ - using ee:b8:12:54:0c:9f
[    4.060476] GMAC4(ffffff800374xxxx) Invalid MAC@ - using 02:c2:bd:fd:b7:37
[    4.067253] GMAC5(ffffff80040cxxxx) Invalid MAC@ - using 8e:f0:ae:3d:d2:97
[    4.274632] GMAC6(ffffff800374xxxx) Invalid MAC@ - using c6:65:2a:ea:8e:b4
[    4.274829] Aquantia AQR113C 90000.mdio-1:08: FW 5.4, Build 4, Provisioning 1
[    4.286016] **********************************************************
[    4.287607] * NSS Data Plane driver
[    4.294023] **********************************************************
[    4.450037] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[    4.450089] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 1
[    4.454584] xhci-hcd xhci-hcd.1.auto: hcc params 0x0220fe65 hci version 0x110 quirks 0x0000000002010010
[    4.462061] xhci-hcd xhci-hcd.1.auto: irq 40, io mem 0x08a00000
[    4.471485] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[    4.477260] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 2
[    4.482820] xhci-hcd xhci-hcd.1.auto: Host supports USB 3.0 SuperSpeed
[    4.490822] hub 1-0:1.0: USB hub found
[    4.496993] hub 1-0:1.0: 1 port detected
[    4.500956] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM.
[    4.505069] hub 2-0:1.0: USB hub found
[    4.512879] hub 2-0:1.0: 1 port detected
[    4.516747] xhci-hcd xhci-hcd.2.auto: xHCI Host Controller
[    4.520487] xhci-hcd xhci-hcd.2.auto: new USB bus registered, assigned bus number 3
[    4.525941] xhci-hcd xhci-hcd.2.auto: hcc params 0x0220fe65 hci version 0x110 quirks 0x0000000002010010
[    4.533369] xhci-hcd xhci-hcd.2.auto: irq 41, io mem 0x08c00000
[    4.542806] xhci-hcd xhci-hcd.2.auto: xHCI Host Controller
[    4.548613] xhci-hcd xhci-hcd.2.auto: new USB bus registered, assigned bus number 4
[    4.554167] xhci-hcd xhci-hcd.2.auto: Host supports USB 3.0 SuperSpeed
[    4.562365] hub 3-0:1.0: USB hub found
[    4.568379] hub 3-0:1.0: 1 port detected
[    4.572453] usb usb4: We don't know the algorithms for LPM for this host, disabling LPM.
[    4.576426] hub 4-0:1.0: USB hub found
[    4.584215] hub 4-0:1.0: 1 port detected
[    4.589429] kmodloader: done loading kernel modules from /etc/modules-boot.d/*
[    4.594503] init: - preinit -
[   14.465207] random: crng init done
[   14.542031] nss-dp 3a001000.dp1 lan1: PHY Link up speed: 1000
[   14.542394] IPv6: ADDRCONF(NETDEV_CHANGE): lan1: link becomes ready
Press the [f] key and hit [enter] to enter failsafe mode
Press the [1], [2], [3] or [4] key and hit [enter] to select the debug level
[   16.602467] loop0: detected capacity change from 0 to 122880
[   16.665255] loop0: detected capacity change from 122880 to 108672
[   16.684665] EXT4-fs (loop0): mounted filesystem with ordered data mode. Quota mode: disabled.
[   16.685826] mount_root: overlay filesystem has not been fully initialized yet
[   16.693820] mount_root: switching to ext4 overlay
[   16.700374] overlayfs: null uuid detected in lower fs '/', falling back to xino=off,index=off,nfs_export=off.
[   16.705289] urandom-seed: Seed file not found (/etc/urandom.seed)
[   16.737083] nss-dp 3a001000.dp1 lan1: PHY Link is down
[   16.740207] procd: - early -
[   16.741189] procd: - watchdog -
[   17.273906] procd: - watchdog -
[   17.274446] procd: - ubus -
[   17.430641] procd: - init -
Please press Enter to activate this console.
[   17.580361] kmodloader: loading kernel modules from /etc/modules.d/*
[   17.618446] hid: raw HID events driver (C) Jiri Kosina
[   17.627142] Bluetooth: Core ver 2.22
[   17.627263] NET: Registered PF_BLUETOOTH protocol family
[   17.629791] Bluetooth: HCI device and connection manager initialized
[   17.635100] Bluetooth: HCI socket layer initialized
[   17.641566] Bluetooth: L2CAP socket layer initialized
[   17.646053] Bluetooth: SCO socket layer initialized
[   17.652139] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[   17.655930] Bluetooth: BNEP filters: protocol multicast
[   17.661482] Bluetooth: BNEP socket layer initialized
[   17.668949] usbcore: registered new interface driver btusb
[   17.672029] Loading modules backported from Linux version v6.5-0-g2dde18cd1d8f
[   17.676946] Backport generated by backports.git v5.15.92-1-56-g5fb2ccb6b9e8
[   17.685075] Bluetooth: HCI UART driver ver 2.3
[   17.691001] Bluetooth: HCI UART protocol H4 registered
[   17.695505] Bluetooth: HCI UART protocol BCSP registered
[   17.701337] Bluetooth: HIDP (Human Interface Emulation) ver 1.2
[   17.706117] Bluetooth: HIDP socket layer initialized
[   17.717650] NET: Registered PF_QIPCRTR protocol family
[   17.720022] Bluetooth: RFCOMM TTY layer initialized
[   17.721903] Bluetooth: RFCOMM socket layer initialized
[   17.726696] Bluetooth: RFCOMM ver 1.11
[   17.733504] hwmon hwmon1: temp1_input not attached to any thermal zone
[   17.764404] PPP generic driver version 2.4.2
[   17.764993] NET: Registered PF_PPPOX protocol family
[   17.765318] urngd: v1.0.2 started.
[   17.774986] ath11k c000000.wifi: ipq8074 hw2.0
[   17.775917] ath11k c000000.wifi: FW memory mode: 0
[   17.780560] remoteproc remoteproc0: powering up cd00000.q6v5_wcss
[   17.785439] remoteproc remoteproc0: Booting fw image IPQ8074/q6_fw.mdt, size 668
[   18.511582] remoteproc remoteproc0: remote processor cd00000.q6v5_wcss is now up
[   18.516115] kmodloader: done loading kernel modules from /etc/modules.d/*
[   18.555624] ath11k c000000.wifi: qmi ignore invalid mem req type 3
[   18.563080] ath11k c000000.wifi: chip_id 0x0 chip_family 0x0 board_id 0xff soc_id 0xffffffff
[   18.563116] ath11k c000000.wifi: fw_version 0x290104a5 fw_build_timestamp 2023-08-02 20:32 fw_build_id WLAN.HK.2.9.0.1-01890-QCAHKSWPL_SILICONZ-1
[   19.033713] ath11k c000000.wifi: htt event 48 not handled
[   21.595321] I/O error, dev loop0, sector 564 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
[   22.687460] br-lan: port 1(lan1) entered blocking state
[   22.687509] br-lan: port 1(lan1) entered disabled state
[   22.691731] device lan1 entered promiscuous mode
[   22.704730] br-lan: port 2(lan2) entered blocking state
[   22.704776] br-lan: port 2(lan2) entered disabled state
[   22.709062] device lan2 entered promiscuous mode
[   22.717580] br-lan: port 3(lan3) entered blocking state
[   22.718845] br-lan: port 3(lan3) entered disabled state
[   22.724031] device lan3 entered promiscuous mode
[   22.732207] br-lan: port 4(lan4) entered blocking state
[   22.733860] br-lan: port 4(lan4) entered disabled state
[   22.739094] device lan4 entered promiscuous mode
[   22.752685] br-lan: port 5(10g) entered blocking state
[   22.752728] br-lan: port 5(10g) entered disabled state
[   22.757140] device 10g entered promiscuous mode
[   25.836051] nss-dp 3a001600.dp4 lan4: PHY Link up speed: 1000
[   25.836123] br-lan: port 4(lan4) entered blocking state
[   25.840781] br-lan: port 4(lan4) entered forwarding state
[   25.846192] IPv6: ADDRCONF(NETDEV_CHANGE): br-lan: link becomes ready
[   26.075777] nss-dp 3a001800.dp5 wan: PHY Link up speed: 1000
[   26.075845] IPv6: ADDRCONF(NETDEV_CHANGE): wan: link becomes ready
[   29.995900] nss-dp 3a001000.dp1 lan1: PHY Link up speed: 1000
[   29.995980] br-lan: port 1(lan1) entered blocking state
[   30.000639] br-lan: port 1(lan1) entered forwarding state

@pwned-pixel
Copy link
Contributor Author

pwned-pixel commented Oct 31, 2023 •
edited
Loading

I cannot see anything suspicious. :/

EDIT: The u_boot_env lines are exactly the same if I remove the mentioned 816-patch on this debug build. But without the failed MAC lines (as before).

@rmilecki
Copy link
Contributor

Please give the latest master a try.

@pwned-pixel
Copy link
Contributor Author

Yep it is working again. Thank you for this fast fix. Kind regards. :)

openwrt-bot pushed a commit that referenced this issue Nov 2, 2023
kernel: fix mtd/NVMEM regression affecting U-Boot env NVMEM driver
0dec0e0 
Fixes: 2073601 ("kernel: backport nvmem v6.6 fixes and v6.7 changes")
Fixes: #13831
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
(cherry picked from commit c997634)
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this issue Nov 9, 2023
@Vladdrako
kernel: fix mtd/NVMEM regression affecting U-Boot env NVMEM driver
ad095d3 
Fixes: b595670 ("kernel: backport nvmem v6.6 fixes and v6.7 changes")
Fixes: openwrt#13831
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
@namiltd namiltd mentioned this issue Nov 11, 2023
Merged
luizluca pushed a commit to luizluca/openwrt that referenced this issue Nov 12, 2023
@luizluca
kernel: fix mtd/NVMEM regression affecting U-Boot env NVMEM driver
87de6c3 
Fixes: b595670 ("kernel: backport nvmem v6.6 fixes and v6.7 changes")
Fixes: openwrt#13831
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
vincejv pushed a commit to vincejv/openwrt that referenced this issue Jan 19, 2024
@vincejv
kernel: fix mtd/NVMEM regression affecting U-Boot env NVMEM driver
cd5862a 
Fixes: b595670 ("kernel: backport nvmem v6.6 fixes and v6.7 changes")
Fixes: openwrt#13831
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
vincejv pushed a commit to vincejv/openwrt that referenced this issue Jan 19, 2024
@vincejv
kernel: fix mtd/NVMEM regression affecting U-Boot env NVMEM driver
a092508 
Fixes: b595670 ("kernel: backport nvmem v6.6 fixes and v6.7 changes")
Fixes: openwrt#13831
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
davintagas pushed a commit to davintagas/ROOterSource2305 that referenced this issue Jun 26, 2024
kernel: fix mtd/NVMEM regression affecting U-Boot env NVMEM driver
0538708 
Fixes: 20736013e910 ("kernel: backport nvmem v6.6 fixes and v6.7 changes")
Fixes: openwrt/openwrt#13831
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
(cherry picked from commit c997634c017294cb38cf6f9a0112860c7e736a53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug issue report with a confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmilecki @robimarko @john-tho @pwned-pixel