New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS#4143 - Image check failed TL-WR1043ND v4 #7071
Comments
ms47: Forcing the sysupgrade seems to have worked okay. |
all current images will be build as. I've checked 19.07.0 which is also build as 10430004 00000001. It seems you had a problem in your custom build. |
I can't confirm @lynxis's conclusion. In 19.07.9, both the ar71xx and ath79 images are correct, but the official ath79 downloads for 21.02.2 and current snapshots contain the incorrect 00000000 hwrev. |
21.02: image/common-tp-link.mk: Device/tplink-safeloader sets hwrev =0x0 But it doesn't sets it to hwrev = 0x1. |
Right, that seems to be the cause. Fortunately the hwrev-based check doesn't exist in ath79 anymore, so it seems to me that we can just fix up the setting in the build to allow upgrades from ar71xx to ath79 without forcing (but I don't have the device here to check). |
@lynxis Yes, most (all?) model-specific upgrade checks were removed in favor of the generic SUPPORTED_DEVICES etc. @AiyionPrime I have pushed a fix to https://git.openwrt.org/?p=openwrt/staging/neoraider.git;a=summary |
It seems to me that 98fbf2e accidentally changed the HWREV from 1 to 0 for all devices based on I think the value only matters for upgrades from ar71xx to ath79. I'll see if I can compile a list of devices that might need to be fixed up as well (or if reverting 98fbf2e would be the most correct fix). |
Tested the commit from your staging tree, works well. Thanks! |
The TL-WR1043ND v4 seems to be the only affected device after all. Looking at all tplink-safeloader devices in current OpenWrt master, only two set HWID to something different than 0: The TL-WR1043ND v4 and the TL-WA850RE v2. TL-WA850RE v2 used a HWREV of 0 in ar71xx as well. Assuming that there are no devices that need HWID = 0 and HWREV = 1, the rest should be fine. |
Required to allow sysupgrades from OpenWrt 19.07. Closes openwrt#7071 Fixes: 98fbf2e ("ath79: move TPLINK_HWID/_HWREV to parent for tplink-safeloader") Tested-by: J. Burfeind <git@aiyionpri.me> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Required to allow sysupgrades from OpenWrt 19.07. Closes openwrt#7071 Fixes: 98fbf2e ("ath79: move TPLINK_HWID/_HWREV to parent for tplink-safeloader") Tested-by: J. Burfeind <git@aiyionpri.me> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Required to allow sysupgrades from OpenWrt 19.07. Closes openwrt#7071 Fixes: ea7230b ("ath79: move TPLINK_HWID/_HWREV to parent for tplink-safeloader") Tested-by: J. Burfeind <git@aiyionpri.me> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> (cherry picked from commit fcd675e)
ms47:
Device: TPLink TL-WR1043ND(EU)Ver:4.0
The device is running custom-built 19.07.3 (r11182-5af8da3787) openwrt-ar71xx-generic-tl-wr1043nd-v4-squashfs-factory.bin image.
I want to flash custom built 21.02.1 (r16325-88151b8303) openwrt-ath79-generic-tplink_tl-wr1043nd-v4-squashfs-sysupgrade.bin,
but get "Image check failed" error.
Opening this ticket as per https://openwrt.org/docs/guide-user/installation/ar71xx.to.ath79#if_your_device_is_not_supported_by_the_image
The output of sysupgrade looks like this:
sysupgrade -n /tmp/openwrt-ath79-generic-tplink_tl-wr1043nd-v4-squashfs-sysupgrade.bin
Invalid image, hardware ID mismatch, hw:10430004 00000001 image:10430004 00000000.
Image check failed.
The text was updated successfully, but these errors were encountered: