Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#4143 - Image check failed TL-WR1043ND v4 #7071

Closed
openwrt-bot opened this issue Nov 21, 2021 · 10 comments · Fixed by sdhz153/openwrt#13
Closed

FS#4143 - Image check failed TL-WR1043ND v4 #7071

openwrt-bot opened this issue Nov 21, 2021 · 10 comments · Fixed by sdhz153/openwrt#13
Assignees
Labels
flyspray release/21.02 target/ath79

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Nov 21, 2021

ms47:

Device: TPLink TL-WR1043ND(EU)Ver:4.0

The device is running custom-built 19.07.3 (r11182-5af8da3787) openwrt-ar71xx-generic-tl-wr1043nd-v4-squashfs-factory.bin image.

I want to flash custom built 21.02.1 (r16325-88151b8303) openwrt-ath79-generic-tplink_tl-wr1043nd-v4-squashfs-sysupgrade.bin,
but get "Image check failed" error.

Opening this ticket as per https://openwrt.org/docs/guide-user/installation/ar71xx.to.ath79#if_your_device_is_not_supported_by_the_image

The output of sysupgrade looks like this:

sysupgrade -n /tmp/openwrt-ath79-generic-tplink_tl-wr1043nd-v4-squashfs-sysupgrade.bin

Invalid image, hardware ID mismatch, hw:10430004 00000001 image:10430004 00000000.
Image check failed.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Nov 21, 2021

ms47:

Forcing the sysupgrade seems to have worked okay.

@aparcar aparcar added the release/21.02 label Feb 22, 2022
@lynxis
Copy link
Member

@lynxis lynxis commented Mar 13, 2022

all current images will be build as.
10430004 00000001 (hwid hwrev)

I've checked 19.07.0 which is also build as 10430004 00000001. It seems you had a problem in your custom build.

@lynxis lynxis closed this as completed Mar 13, 2022
@ynezz ynezz added the target/ath79 label Mar 14, 2022
@NeoRaider NeoRaider reopened this Mar 25, 2022
@NeoRaider
Copy link
Member

@NeoRaider NeoRaider commented Mar 25, 2022

I can't confirm @lynxis's conclusion. In 19.07.9, both the ar71xx and ath79 images are correct, but the official ath79 downloads for 21.02.2 and current snapshots contain the incorrect 00000000 hwrev.

@NeoRaider NeoRaider self-assigned this Mar 25, 2022
@lynxis
Copy link
Member

@lynxis lynxis commented Mar 25, 2022

21.02: image/common-tp-link.mk: Device/tplink-safeloader sets hwrev =0x0
21.02: image/generic-tp-link.mk: Device/tplink_tl-wr1043nd-v4 uses it as template.

But it doesn't sets it to hwrev = 0x1.

@NeoRaider
Copy link
Member

@NeoRaider NeoRaider commented Mar 25, 2022

Right, that seems to be the cause. Fortunately the hwrev-based check doesn't exist in ath79 anymore, so it seems to me that we can just fix up the setting in the build to allow upgrades from ar71xx to ath79 without forcing (but I don't have the device here to check).

@lynxis
Copy link
Member

@lynxis lynxis commented Mar 25, 2022

It seems 98fbf2e accidently changed the hwrev. @adschm
Why is the hwrev based check not anymore needed? Because it directly uses the OpenWrt specific comp check?
I would fix it in 21.02 and master by setting it to 0x1. It would be great if we could check the differences between 19.07

@NeoRaider
Copy link
Member

@NeoRaider NeoRaider commented Mar 25, 2022

@lynxis Yes, most (all?) model-specific upgrade checks were removed in favor of the generic SUPPORTED_DEVICES etc.

@AiyionPrime I have pushed a fix to https://git.openwrt.org/?p=openwrt/staging/neoraider.git;a=summary
Please check that both upgrades from 19.07 to master and from master to master are working now without -F.

@NeoRaider
Copy link
Member

@NeoRaider NeoRaider commented Mar 25, 2022

It seems to me that 98fbf2e accidentally changed the HWREV from 1 to 0 for all devices based on Device/tplink-safeloader that didn't set it explicitly, which were roughly 30 at the time...

I think the value only matters for upgrades from ar71xx to ath79. I'll see if I can compile a list of devices that might need to be fixed up as well (or if reverting 98fbf2e would be the most correct fix).

@AiyionPrime
Copy link
Contributor

@AiyionPrime AiyionPrime commented Mar 25, 2022

Tested the commit from your staging tree, works well. Thanks!

@NeoRaider
Copy link
Member

@NeoRaider NeoRaider commented Mar 25, 2022

The TL-WR1043ND v4 seems to be the only affected device after all.

Looking at all tplink-safeloader devices in current OpenWrt master, only two set HWID to something different than 0: The TL-WR1043ND v4 and the TL-WA850RE v2. TL-WA850RE v2 used a HWREV of 0 in ar71xx as well. Assuming that there are no devices that need HWID = 0 and HWREV = 1, the rest should be fine.

jow- pushed a commit that referenced this issue Mar 25, 2022
Required to allow sysupgrades from OpenWrt 19.07.

Closes #7071

Fixes: 98fbf2e ("ath79: move TPLINK_HWID/_HWREV to parent for tplink-safeloader")
Tested-by: J. Burfeind <git@aiyionpri.me>
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
(cherry picked from commit 8ba71f1)
jow- pushed a commit that referenced this issue Mar 25, 2022
Required to allow sysupgrades from OpenWrt 19.07.

Closes #7071

Fixes: 98fbf2e ("ath79: move TPLINK_HWID/_HWREV to parent for tplink-safeloader")
Tested-by: J. Burfeind <git@aiyionpri.me>
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
(cherry picked from commit 8ba71f1)
zhanhb pushed a commit to zhanhb/openwrt that referenced this issue Mar 25, 2022
Required to allow sysupgrades from OpenWrt 19.07.

Closes openwrt#7071

Fixes: 98fbf2e ("ath79: move TPLINK_HWID/_HWREV to parent for tplink-safeloader")
Tested-by: J. Burfeind <git@aiyionpri.me>
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this issue Mar 26, 2022
Required to allow sysupgrades from OpenWrt 19.07.

Closes openwrt#7071

Fixes: 98fbf2e ("ath79: move TPLINK_HWID/_HWREV to parent for tplink-safeloader")
Tested-by: J. Burfeind <git@aiyionpri.me>
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray release/21.02 target/ath79
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants