qmi: read sim status problem

[obsy]

81832b3

Reading pin status in this way is wrong, this code return empty values. See debug script:

root@OpenWrt:~# uqmi -s -d /dev/cdc-wdm0 --get-pin-statu
{"pin1_status":"disabled","pin1_verify_tries":3,"pin1_unblock_tries":10,"pin2_status":"not_verified","pin2_verify_tries":3,"pin2_unblock_tries":10}

root@OpenWrt:~# uqmi -s -d /dev/cdc-wdm0  --uim-get-sim-state
{"pin1_status":"disabled","pin1_verify_tries":3,"pin1_unlock_tries":10,"pin2_status":"not_verified","pin2_verify_tries":3,"pin2_unlock_tries":10}

root@OpenWrt:~# cat ./a.sh 
#!/bin/sh
device=/dev/cdc-wdm0

. /usr/share/libubox/jshn.sh

json_load "$(uqmi -s -d "$device" --get-pin-status)" 2>&1 | grep -q Failed &&
	json_load "$(uqmi -s -d "$device" --uim-get-sim-state)"
json_get_var pin1_status pin1_status
json_get_var pin1_verify_tries pin1_verify_tries

echo "pin1_status: $pin1_status"
echo "pin1_verify_tries: $pin1_verify_tries"

root@OpenWrt:~#  ./a.sh 
pin1_status: 
pin1_verify_tries: 

root@OpenWrt:~# sh -x  ./a.sh 
+ device=/dev/cdc-wdm0
+ . /usr/share/libubox/jshn.sh
+ grep -q Failed
+ uqmi -s -d /dev/cdc-wdm0 --get-pin-status
+ json_load '{"pin1_status":"disabled","pin1_verify_tries":3,"pin1_unblock_tries":10,"pin2_status":"not_verified","pin2_verify_tries":3,"pin2_unblock_tries":10}'
+ json_get_var pin1_status pin1_status
+ local '__dest=pin1_status'
+ local __cur
+ _json_get_var __cur JSON_CUR
+ eval '__cur="$JSON_CUR"'
+ __cur=
+ local '__var=_pin1_status'
+ eval 'export -- "pin1_status=${_pin1_status:-}"; [ -n "${_pin1_status+x}${3+x}" ]'
+ export -- 'pin1_status='
+ '[' -n  ]
+ json_get_var pin1_verify_tries pin1_verify_tries
+ local '__dest=pin1_verify_tries'
+ local __cur
+ _json_get_var __cur JSON_CUR
+ eval '__cur="$JSON_CUR"'
+ __cur=
+ local '__var=_pin1_verify_tries'
+ eval 'export -- "pin1_verify_tries=${_pin1_verify_tries:-}"; [ -n "${_pin1_verify_tries+x}${3+x}" ]'
+ export -- 'pin1_verify_tries='
+ '[' -n  ]
+ echo 'pin1_status: '
pin1_status: 
+ echo 'pin1_verify_tries: '
pin1_verify_tries: 
root@OpenWrt:~# 

Tested with Quectel EC20

CC: @dangowrt

[dangowrt]

@obsy I still had this on my to-do list. What was your reason for closing the issue now?

[obsy]

Because I don't know what the issue is. This code working for Askey modem, working for BroadMobi BM806U and not working for my Quectel EC20. I don't know if there is anything wrong with him. If you can, check it with some qmi modem.

[dangowrt]

Does the output of --get-pin-status and --uim-get-sim-state @obsy has provided earlier belong to that Quectel EC20 modem?

[obsy]

Yes, from this EC20.

[obsy]

See:

#  ./a.sh 
{"pin1_status":"disabled","pin1_verify_tries":3,"pin1_unblock_tries":10,"pin2_status":"not_verified","pin2_verify_tries":3,"pin2_unblock_tries":10}
{ }
{ "pin1_status": "disabled", "pin1_verify_tries": 3, "pin1_unblock_tries": 10, "pin2_status": "not_verified", "pin2_verify_tries": 3, "pin2_unblock_tries": 10 }

# cat a.sh 
#!/bin/sh
device=/dev/cdc-wdm0

. /usr/share/libubox/jshn.sh

O="$(uqmi -s -d "$device" --get-pin-status)" 
echo "$O"
json_load "$O" | grep Failed
json_dump
json_load "$O"
json_dump

exit 0

grep Failed is the problem?

[dangowrt]

Please try if this patch fixes it then

diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
index ad577ea317..8b8ba014ce 100755
--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
+++ b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
@@ -105,9 +105,9 @@ proto_qmi_setup() {
                        }
                }
        else
-               . /usr/share/libubox/jshn.sh
-               json_load "$(uqmi -s -d "$device" --get-pin-status)" 2>&1 | grep -q Failed &&
-                       json_load "$(uqmi -s -d "$device" --uim-get-sim-state)"
+               local pin_json="$(uqmi -s -d "$device" --get-pin-status)"
+               [ "${pin_json:0:1}" = "{" ] || pin_json="$(uqmi -s -d "$device" --uim-get-sim-state)"
+               json_load "$pin_json"
                json_get_var pin1_status pin1_status
                json_get_var pin1_verify_tries pin1_verify_tries
 

This should have the desired effect (and we can remove . /usr/share/libubox/jshn.sh because it's included in netifd-proto.sh anyway already)

[obsy]

Ok. it works. But looks very bad. Maybe like this:

pin_json="$(uqmi -s -d "$device" --get-pin-status)"
pin=$(echo "$pin_json" | jsonfilter -q -e '@.pin1_status')
[ -z "$pin" ] && pin_json="$(uqmi -s -d "$device" --uim-get-sim-state)"
 json_load "$pin_json"

Duplicate, but tests if it's really json.

[dangowrt]

How about

diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
index ad577ea317..c2c5fc1eca 100755
--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
+++ b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
@@ -105,10 +105,12 @@ proto_qmi_setup() {
                        }
                }
        else
-               . /usr/share/libubox/jshn.sh
-               json_load "$(uqmi -s -d "$device" --get-pin-status)" 2>&1 | grep -q Failed &&
-                       json_load "$(uqmi -s -d "$device" --uim-get-sim-state)"
+               json_load "$(uqmi -s -d "$device" --get-pin-status)"
                json_get_var pin1_status pin1_status
+               if [ -z "$pin1_status" ]; then
+                       json_load "$(uqmi -s -d "$device" --uim-get-sim-state)"
+                       json_get_var pin1_status pin1_status
+               fi
                json_get_var pin1_verify_tries pin1_verify_tries
 
                case "$pin1_status" in

That would avoid duplicate parsing and also avoid wildly checking for the first character of the replied string...

[obsy]

Ok.