mt76: move mt7921 firmware from mt7921e to mt7921-firmware #10381
Conversation
|
@nbd168 can you have a look at this please. Thanks. |
|
Im confused, don't you have to rename dependencies, too? |
|
kmod-mt7921e, kmod-mt7921u and kmod-mt7921s already all depend on kmod-mt7921-common, it's just that the firmware files are packaged only in the kmod-mt7921e package, thus if you install - for said - kmod-mt7921u package you have kmod-mt7921-common installed as a dependency but no firmware files installed. If firmware files are packaged with kmod-mt7921-common, you have them installed with any kmod-mt7921x package that depends on kmod-mt7921-common. |
|
I believe the support for MT7922 is on the way and they use different firmware, so it's not a good idea to squash mt7921 firmware into kmod-mt7921-common. |
|
kmod-mt7921-common could provide firmware files for both chips and the driver would load the ones needed based on chip id. |
|
This will significantly increase the size of the package, which is sensitive for embedded systems such as openwrt. It's better to add a new package like kmod-mt7921-firmware. |
|
You're probably right regarding package size when both chips will be supported and firmware for 7922 added in openwrt's mt76 packages, so a new kmod-mt7921-firmware package for now and another kmod-mt7922-firmware package later might be a better solution. |
coudu
changed the title
|
Modified as per @DragonBluep suggestion. Let's wait for mt76 gurus' opinion on this matter. |
|
in the commit message,
mt7922? |
well spotted, thanks. corrected and rebased. |
coudu
force-pushed
the
fix-mt7921-fw
branch
from
47a8a04
to
12f94ce
Compare
As others kmod-mt7921x need firmware files too, it is better to move it to its own package rather than in kmod-mt7921e package. It could have been moved to mt7921-common but with mt7922 support comming and needing another firmware it is better to package both firmwares individually. Signed-off-by: Pascal Coudurier <coudu@gmx.com>
|
@nbd168 can you have a look at this please. Thanks. |
|
Done in another commit here |
|
Sorry, I didn't search and wasn't aware of your PR before creating a new one :\ |
as others kmod-mt7921x need firmware files too, it is better topackage it with kmod-mt7921-common rather than only with kmod-mt7921e
As others kmod-mt7921x need firmware files too, it is better to
move it to its own package rather than in kmod-mt7921e package.
It could have been moved to mt7921-common but with mt7922 support
comming and needing another firmware it is better to package both
firmwares individually.
Signed-off-by: Pascal Coudurier coudu@gmx.com