tools/cmake: fix download url with make variables #10754
Conversation
github-actions
bot
added
the
build/scripts/tools
| @@ -8,12 +8,13 @@ include $(TOPDIR)/rules.mk | |||
|
|
|||
| PKG_NAME:=cmake | |||
| PKG_VERSION:=3.24.1 | |||
| PKG_VERSION_MAJOR:=$(word 1,$(subst ., ,$(PKG_VERSION))).$(word 2,$(subst ., ,$(PKG_VERSION))) | |||
There was a problem hiding this comment.
This is wonderful. A lot of packages in the packages feed can take advantage of this.
There was a problem hiding this comment.
Wonder... should we make this an helper? @neheb
|
@mpratt14 I wonder if you can rebase this on top of master so this gets flagged as merged. You disabled maintainers force push so I can't do it and the only option is to manually merge and flag this as closed :( |
|
Isn't there a reason that PRs are never merged through github, and instead always manually? something like, github is a one-way mirror and then fast-forward from git.openwrt.org would fail? that's the reason they added the review block for merging "At least 6 approving reviews are required by reviewers with write access"?? or is it just to prevent accidental misclicks or something |
|
@mpratt14 yes but with extra step they can still be flagged as merged as you can see some closed pr recently The extra step needs to rebase the pr on top of master so they can be merged with -ff-only. Normally I would do this for the user by force pushing it but is not possible if the user block this feature for the pr. |
|
got it 👍🏼 |
Use a make variable pattern for the url so that only one version number needs to be changed when version is bumped. Signed-off-by: Michael Pratt <mcpratt@pm.me>
mpratt14
force-pushed
the
download-cmake-url
branch
from
9c780a0
to
1e726ba
Compare
|
and by the way, the reason is that I update all my branches together with |
|
@mpratt14 see merged :D anyway it's ok it was just to clear why force push is needed and why it's problematic. Everyone has it's reason it's just a pitty to close pr without giving actual credits that they were merged. |
Use a make variable pattern for the url
so that only one version number needs to be changed when version is bumped.
Signed-off-by: Michael Pratt mcpratt@pm.me