Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uboot-mediatek: fixes the defconfig typo #10890

Merged
merged 2 commits into from Oct 11, 2022
Merged

Conversation

aiamadeus
Copy link
Contributor

CONFIG_CMD_MTDPART does not exist, fix it.

@github-actions github-actions bot added the core packages pull request/issue for core (in-tree) packages label Oct 4, 2022
@Ansuel Ansuel self-assigned this Oct 6, 2022
@Ansuel
Copy link
Member

Ansuel commented Oct 6, 2022

@aiamadeus can you split this to 2 commit one for each changed patch and add the relevant Fixes tag to them?

A quick git blame

  • patch 412 e9ad412
    e9ad412049c3 ("uboot-mediatek: add build for Ubiquiti Networks UniFi 6 LR")
  • patch 410 ed50004
    ed5000431940 ("uboot-mediatek: add support for Linksys E8450")

Feel free to ask for help

@aiamadeus
Copy link
Contributor Author

can you split this to 2 commit one for each changed patch and add the relevant Fixes tag to them?

Thanks, I have changed it.

@Ansuel
Copy link
Member

Ansuel commented Oct 10, 2022

@aiamadeus if you can't i will fix it for you but fixes tag needs to stay in the same line, no wrapping :D
Just tell me what do you prefer (me fixing or you fix)

@Ansuel Ansuel added the ready for merge pull request reviewed and prepared for merge label Oct 10, 2022
CONFIG_CMD_MTDPART does not exist, fix it.

Fixes: ed50004 ("uboot-mediatek: add support for Linksys E8450")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
CONFIG_CMD_MTDPART does not exist, fix it.

Fixes: e9ad412 ("uboot-mediatek: add build for Ubiquiti Networks UniFi 6 LR")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
@openwrt-bot openwrt-bot merged commit bb21209 into openwrt:master Oct 11, 2022
@aiamadeus aiamadeus deleted the uboot branch October 11, 2022 16:04
fengmushu pushed a commit to fengmushu/openwrt that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages ready for merge pull request reviewed and prepared for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants