-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bcm53xx: Specify all RAM for linksys ea6500 v2 #10940
Conversation
@alealexpro100 thanks for the pr. you should add a commit description and also use Fixes tag referring to the change related |
@alealexpro100 the patch is not good but one last thing space between commit description and sob. Also would be good something like in the title And same in commit description
|
e492a4f
to
f080417
Compare
@alealexpro100 sorry my bad... can you wrap this to 80 columns and this is ready? or if you want i can do it for you. |
Linksys ea6500-v2 have 256MB of ram. Currently we only use 128MB. Expand the definition to use all the available RAM. Signed-off-by: Aleksey Nasibulin <alealexpro100@ya.ru> [ wrap to 80 columns ] Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
It would be great if You do so. Thank You! |
@alealexpro100: please send this patch for upstream, I really don't want to maintain such trivial patches downstream. Personally I wouldn't even accept this without having it sent upstream. Cc @Ansuel |
@rmilecki sorry! didn't notice the dts was present upstream! Stupid me considering this was a patch and we were not editing the dts directly. |
Ping @alealexpro100, can you send proper patch? |
What do You mean? Should I send this patch to upstream or edit it? |
Please see my previous comment:
|
I am not familiar with sending patches to upstream process. May be it is possible just remove this patch from a tree? |
OK, I'll drop it during the next bump |
Thank You. |
This patch is ready and easy to upstream but noone is willing to take care of it. Drop it (as requested) to simplify maintenance. Link: openwrt/openwrt#10940 (comment) Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
I'm proposing this upstream and they are asking if some config are required like sparse memory support. Can someone help me with that? |
Actually the patch was accepted upstream so we need to backport it. It will also eventually backported and later dropped! |
This patch is ready and easy to upstream but noone is willing to take care of it. Drop it (as requested) to simplify maintenance. Link: openwrt#10940 (comment) Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
This patch is ready and easy to upstream but noone is willing to take care of it. Drop it (as requested) to simplify maintenance. Link: openwrt/openwrt#10940 (comment) Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
This allows to use all memory on both ea6500 v2 and ea6700.
Tested it with file in tmpfs and stress utility. Looks like it works correctly.
It is correction of this pull request.
Signed-off-by: Aleksey Nasibulin alealexpro100@ya.ru