Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcm53xx: Specify all RAM for linksys ea6500 v2 #10940

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

alealexpro100
Copy link
Contributor

This allows to use all memory on both ea6500 v2 and ea6700.

Tested it with file in tmpfs and stress utility. Looks like it works correctly.

It is correction of this pull request.

Signed-off-by: Aleksey Nasibulin alealexpro100@ya.ru

@github-actions github-actions bot added the target/bcm53xx pull request/issue for bcm53xx target label Oct 11, 2022
@Ansuel
Copy link
Member

Ansuel commented Oct 11, 2022

@alealexpro100 thanks for the pr. you should add a commit description and also use Fixes tag referring to the change related

@github-actions github-actions bot removed the target/bcm53xx pull request/issue for bcm53xx target label Oct 11, 2022
@alealexpro100 alealexpro100 reopened this Oct 11, 2022
@github-actions github-actions bot added the target/bcm53xx pull request/issue for bcm53xx target label Oct 11, 2022
@Ansuel
Copy link
Member

Ansuel commented Oct 12, 2022

@alealexpro100 the patch is not good but one last thing space between commit description and sob.

Also would be good something like in the title extend RAM to full 256MB

And same in commit description

Linksys ea6500-v2 have 256MB of ram. Currently we only use 128MB. Expand the definition
to use all the available RAM.

@Ansuel
Copy link
Member

Ansuel commented Oct 13, 2022

@alealexpro100 sorry my bad... can you wrap this to 80 columns and this is ready? or if you want i can do it for you.

@Ansuel Ansuel added the ready for merge pull request reviewed and prepared for merge label Oct 13, 2022
@Ansuel Ansuel self-assigned this Oct 13, 2022
Linksys ea6500-v2 have 256MB of ram. Currently we only use 128MB.
Expand the definition to use all the available RAM.

Signed-off-by: Aleksey Nasibulin <alealexpro100@ya.ru>
[ wrap to 80 columns ]
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
@alealexpro100
Copy link
Contributor Author

alealexpro100 commented Oct 13, 2022

@alealexpro100 sorry my bad... can you wrap this to 80 columns and this is ready? or if you want i can do it for you.

It would be great if You do so. Thank You!

@rmilecki
Copy link
Contributor

@alealexpro100: please send this patch for upstream, I really don't want to maintain such trivial patches downstream.

Personally I wouldn't even accept this without having it sent upstream.

Cc @Ansuel

@Ansuel
Copy link
Member

Ansuel commented Oct 17, 2022

@rmilecki sorry! didn't notice the dts was present upstream!

Stupid me considering this was a patch and we were not editing the dts directly.

@rmilecki
Copy link
Contributor

Ping @alealexpro100, can you send proper patch?

@alealexpro100
Copy link
Contributor Author

Ping @alealexpro100, can you send proper patch?

What do You mean? Should I send this patch to upstream or edit it?

@rmilecki
Copy link
Contributor

What do You mean? Should I send this patch to upstream or edit it?

Please see my previous comment:

@alealexpro100: please send this patch for upstream, I really don't want to maintain such trivial patches downstream.

@alealexpro100
Copy link
Contributor Author

What do You mean? Should I send this patch to upstream or edit it?

Please see my previous comment:

@alealexpro100: please send this patch for upstream, I really don't want to maintain such trivial patches downstream.

I am not familiar with sending patches to upstream process. May be it is possible just remove this patch from a tree?

@rmilecki
Copy link
Contributor

OK, I'll drop it during the next bump

@alealexpro100
Copy link
Contributor Author

alealexpro100 commented Nov 17, 2022

Thank You.

openwrt-bot pushed a commit to lede-project/source that referenced this pull request Jul 11, 2023
This patch is ready and easy to upstream but noone is willing to take
care of it. Drop it (as requested) to simplify maintenance.

Link: openwrt/openwrt#10940 (comment)
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
@stintel
Copy link
Member

stintel commented Jul 11, 2023

I am not familiar with sending patches to upstream process. May be it is possible just remove this patch from a tree?

https://docs.kernel.org/process/submitting-patches.html

@Ansuel
Copy link
Member

Ansuel commented Jul 12, 2023

I'm proposing this upstream and they are asking if some config are required like sparse memory support. Can someone help me with that?

@Ansuel
Copy link
Member

Ansuel commented Jul 12, 2023

Actually the patch was accepted upstream so we need to backport it. It will also eventually backported and later dropped!

Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request Aug 1, 2023
This patch is ready and easy to upstream but noone is willing to take
care of it. Drop it (as requested) to simplify maintenance.

Link: openwrt#10940 (comment)
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Mr-3S pushed a commit to Mr-3S/openwrt-nanopi-r6s that referenced this pull request Nov 24, 2023
This patch is ready and easy to upstream but noone is willing to take
care of it. Drop it (as requested) to simplify maintenance.

Link: openwrt/openwrt#10940 (comment)
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge pull request reviewed and prepared for merge target/bcm53xx pull request/issue for bcm53xx target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants