Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramips:gsw-mt7621 switch reset code fix #112

Closed
wants to merge 2 commits into from

Conversation

AutumnShie
Copy link

@AutumnShie AutumnShie commented Oct 5, 2016

in gsw-mt7621.c mt7621_hw_init.
The switch reset is not FE Reset, it need more delay in each step for reset working.

merge from mtk sdk.

Signed-off-by: Autumn Shie autumn.shie@gmail.com

in gsw-mt7621.c mt7621_hw_init.
 The switch reset is not FE Reset, it need more delay in each step for reset working.

merge from mtk sdk.
@AutumnShie
Copy link
Author

AutumnShie commented Oct 5, 2016

I can't see the detail of the checks fail.
Could someone help me?
This patch file has no error in my local build. Why there?

Signed-off-by: Autumn Shie autumn.shie@gmail.com

modify patch file and commit again
@blogic
Copy link
Contributor

blogic commented Oct 15, 2016

this patch seems to add code just to remove it again making the patch a no-op. please explain what this patch actually fixes.

@AutumnShie
Copy link
Author

switch need to be fully reset before setting it. The original code use fe reset function but the delay is too short, it causes the link led control in port 0 not working correctly. I merge frome MTK drive with correct delay time for hw reset.

@blogic
Copy link
Contributor

blogic commented Oct 15, 2016

ok, there are 2 patches, both need to be folded into a single patch. also please add your Signed-off-by line to the patch and then prefix the subject with "ramips:"

@AutumnShie
Copy link
Author

Sorry, I don't know how to folded into a single patch. Does I need to create new pull request again?

@AutumnShie AutumnShie changed the title gsw-mt7621 switch reset code fix ramips:gsw-mt7621 switch reset code fix Oct 15, 2016
@AutumnShie AutumnShie closed this Oct 15, 2016
@AutumnShie AutumnShie deleted the patch-3 branch October 15, 2016 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants