kernel: 5.15: disable kmod-ptp for broken targets #11486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in linux 5.15, mv88e6xxx dsa driver cannot be built-in as described in commit 97c77ff This disables kmod-ptp, which is dragging the driver to become a kmod, for the following affected targets in linux 5.15: - kirkwood - mvebu - qoriq Signed-off-by: Johnny S. Lee <foss@jsl.io>
github-actions
bot
added
core packages
johnnyslee
referenced
this pull request
Dec 13, 2022
This reverts commit 5429411 as upstream in commit e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies") has changed `PTP_1588_CLOCK` dependency handling in 5.15 kernel. That currently leads to `CONFIG_NET_DSA_MV88E6XXX=m` in images produced by buildbots due to `CONFIG_ALL_KMODS=y` config option being used in those builds, which leads to a broken LAN bridge network on several devices. References: https://lists.infradead.org/pipermail/openwrt-devel/2022-December/039950.html Signed-off-by: Petr Štetiar <ynezz@true.cz>
|
Just sharing my opinion. What I am doing for almost 6 months in my environment is to have separate kmod package with the Marvell switch. You can look here https://gitlab.nic.cz/turris/os/build/-/blob/hbk/patches/openwrt/a-new-kernel-5.15/0012-separate-kmod-marvell-switch.patch this ensures that the Marvell switch is indeed there if you can not rely on kernel configs. It was also described here https://lists.openwrt.org/pipermail/openwrt-devel/2022-December/039972.html , so it was no need to disable kmod-ptp, but I think others should decide what is preferred. |
|
See also: Discussion in 97c77ff |
|
Better solution here: 97c77ff#commitcomment-93150734 |
|
Replaced by PR #11522 |
fengmushu
pushed a commit
to fengmushu/openwrt
that referenced
this pull request
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in linux 5.15, mv88e6xxx dsa driver cannot be built-in as described in commit 97c77ff
This disables kmod-ptp, which is dragging the driver to become a kmod, for the following affected targets in linux 5.15: