libdeflate: Update to v1.17 #11788
libdeflate: Update to v1.17 #11788
Conversation
github-actions
bot
added
the
build/scripts/tools
|
@neheb btw, how can I force a rebuild of a tool? It keeps telling me 'everything is up to date'. |
|
You tried changing the |
|
I think it's because this package is using Host/Clean instead of Host/Uninstall edit: yeah, need to call Host/Clean/Default in that section. |
|
Oh wow it can simply be compiled with good old gcc raw command? Nice! |
Part of the Merge Request already :) but no :( doesn't work. |
So this goes beyond my knowledge (and desire to know) about the OpenWRT build system :p however, no, doesn't seem to make a difference. I tried several combinations, Host/Uninstall, Host/Clean; adding the call (I did push that bit as I saw other tools having it). But a) I have no idea how all of this magic works, and b) I can't force a rebuild to check if it actually compiles. So feel free to merge it on good faith :) or test it somehow. I can't seem to :( Btw, I think logically, It would be uninstall, not clean; but what do I now :) (Who actually does know?) |
|
I'll fix it in the other PR. |
|
@neheb thank you for fixing it in your MR, i'll close this and refer to yours! |
|
So I figured things here, which due to a version bump makes building even easier. |
|
@neheb should be all good now I hope :) |
|
Change it to libdeflate: update to 1.17 |
oliv3r
force-pushed
the
libdeflate
branch
2 times, most recently
from
8f2a570
to
a1f84be
Compare
oliv3r
changed the title
|
Change it to libdeflate: update to 1.17 and keep second commit title lowercase. |
"Officially" Linux and in many git guidelines, you are supposed to start your subject with a capital. I'll make it consistent. |
oliv3r
force-pushed
the
libdeflate
branch
2 times, most recently
from
d1a5dfd
to
24a7bc7
Compare
Like with commit ae614fb ("tools: Improve diffability/maintainability") we also want tools-core to be easy to maintain. While a smaller target, it's still usefull and makes things nice and consistent. To avoid duplicating any tools in the comment, simplify the comment instead. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
The new version of libdeflate makes it a little easier to build it without any build system. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
|
@oliv3r missing separator error |
|
There are some rebase comment left |
CMake depends on (libdeflate-)gunzip, libdeflate depends on Cmake, so we can't win. Luckily libdeflate is _very_ easy to build, without any build system, so lets just manually compile it and be done with it. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
@oliv3r just in case this is rebased on top of master so i can merge without removing your verified tag? |
Not sure what you meant, but it should have been rebased on master (as I always do a fetch; rebase; cycle), but since it's merged, I guess its good :) |
|
(to give you some context... to flag pr as merged they needs to be merged with --ff-only so they have to be rebased on top of master... and by rebasing on top of master i would have dropped your verified tag as i would had to resign them for the force push... but they were rebased so np :D) |
CMake depends on (libdeflate-)gunzip, libdeflate depends on Cmake, so we can't win.
Luckily libdeflate is very easy to build, without any build system, so lets just manually compile it and be done with it.
Signed-off-by: Olliver Schinagl oliver@schinagl.nl