imagebuilder: ability to sign created images #1246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add config option CONFIG_SIGNED_IMAGES so the ImageBuilder would automatically sign the created sha256sums files via usign. This is a usefull feature to allow devices/routers verify firmware images without the need of GPG installed. Signed-off-by: Paul Spooren <mail@aparcar.org>
|
this looks overly complicated, cant we just always sign stuff regardless ? the key is always there even if it is only the auto generated one. |
|
I did not realize there is already some key auto generation. Sure I'm happy to simplify stuff, I just thought to stick with the SDK approach |
|
The whole external signature approach is obsoleted by fwtool + ucert. I'll do my best to integrate this into the ImageBuilder asap, probably at some point during this week. |
|
Glad to hear. What about the key creation part, isn't that still relevant? |
|
That |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config option CONFIG_SIGNED_IMAGES so the ImageBuilder would
automatically sign the created sha256sums files via usign.
This is a usefull feature to allow devices/routers verify firmware
images without the need of GPG installed.
Signed-off-by: Paul Spooren mail@aparcar.org