mac80211: do not enforce start_disabled=1 when staidx>0 #12499
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
core packages
|
mark. |
neheb
reviewed
Apr 30, 2023
Allow to override "start_disabled" to 0 even if there are station interfaces present on the radio. If "start_disabled" is not explicitly defined, the original behaviour of setting it to 1 is retained. In other words, the existence of station interfaces now only controls the default value of "start_disabled", but does not enforce it to 1. Signed-off-by: Manas Sambhus <manas.sambhus+github@gmail.com>
|
Ok, I was still on 22.03 and didn't notice that we have now shifted to ucode-based configuration for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not really understand the purpose of not letting the AP interface start automatically when there are wireless client (station mode) interfaces present on the same wireless radio.
Maybe there are issues in some drivers that do not let this work properly? Or is it because client connection can disrupt the access point interface connectivity? I don't know.
With this patch, I provide an option for the user to override this default behaviour by explicitly setting
start_disabledto0. The existence of station interfaces will only control the default value ofstart_disabledbut the user's preference will always be used if it is explicitly defined.