Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lantiq: mark source only #12515

Merged
merged 1 commit into from May 3, 2023
Merged

lantiq: mark source only #12515

merged 1 commit into from May 3, 2023

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented May 1, 2023

The target is currently broken with Kernel 5.15 and no one in sight to fix it. Instead of stalling the next release indefinitely, make it source only and see if someone steps up to fix it.

@github-actions github-actions bot added the target/lantiq pull request/issue for lantiq target label May 1, 2023
@aparcar aparcar mentioned this pull request May 1, 2023
39 tasks
@abajk
Copy link
Contributor

abajk commented May 1, 2023

I think it would be better to just merge PR #12064. The primary problem is the additional logs that appear on the console coming from the DSA driver. This can be fixed later. Apart from that, everything works fine :)

@mrkiko
Copy link
Contributor

mrkiko commented May 2, 2023

I tend to second this.

@Ansuel
Copy link
Member

Ansuel commented May 2, 2023

I think it would be better to just merge PR #12064. The primary problem is the additional logs that appear on the console coming from the DSA driver. This can be fixed later. Apart from that, everything works fine :)

those logs are not something to ignore... they are dsa failing to add fdb entry... that will result in missing packet or even worse having them forwarded to wrong port or to every port... resulting in a security risk... I'm pretty positive the target will be reintroduced in rc stage.

So this commit it's really just to move the migration further

@aparcar
Copy link
Member Author

aparcar commented May 2, 2023

@Ansuel fell free to merge

The target is currently broken with Kernel 5.15 and no one in sight to
fix it. Instead of stalling the next release indefinitely, make it
source only and see if someone steps up to fix it.

Signed-off-by: Paul Spooren <paul.spooren@rhebo.com>
@openwrt-bot openwrt-bot merged commit c306385 into openwrt:master May 3, 2023
3 checks passed
@abajk
Copy link
Contributor

abajk commented May 3, 2023

The gswip driver is only used by the xrx200 subtarget. Other subtargets should not be affected

@abajk
Copy link
Contributor

abajk commented May 3, 2023

Maybe it is possible to mark as source-only only the xrx200 subtarget?

@dseven
Copy link

dseven commented Jun 20, 2023

Is there any issue open to track this problem with addition of fdb entries, with a concise problem description? It seems unlikely that anything will get done if there's no issue to track it...

I do see the messages on a BT Home Hub 5a, but they only reference MAC addresses of local interfaces (switch ports and wifi phy), not any from other hosts, so I'm not sure these messages are indicative of a real issue. There is #11650 , but I don't think it's related to these messages.

@feckert
Copy link
Member

feckert commented Jul 5, 2023

@Ansuel What is the situation now with the lantiq/xrx200 target? Could the problem be solved with the GSWIP for the next openwrt-23.05 stable? Any news about this problem? I have seen that there is a pull request in the master for the lantiq to port this SOC to 6.1. There are also patches for the GSWIP DSA for 5.15. @hauke Shouldn't these not be merged first into the next stable openwrt-23.05?

@Ansuel
Copy link
Member

Ansuel commented Jul 5, 2023

@feckert can you link these patch? I'm not following gswip but the situation is the same as prev, aka the intention is to ""delay"" release waiting for a not so late fix for lantiq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/lantiq pull request/issue for lantiq target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants