New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ramips: enable flash variable erasure and fix potential lost configuration issues after upgrade #12602
Conversation
Yes, please. Finally reasonable flash performance for MF283+. Thank you! |
1343140
to
855deb1
Compare
|
What is the purpose of the mtd7 test partition and should it not be retained? |
It's just a placeholder that I use to make As long as the start address of the partition is aligned to 64k, it is readable and writable. If the start address of the partition is not aligned to 64k, it will be read only. Fortunately, the |
mark. |
Make use of minor sector size (4k) on supported flash chips to improve spi read/write performance. Tested on ramips/mt7628: Motorola MWR03 Signed-off-by: Shiji Yang <yangshiji66@qq.com>
In kernel 5.15, the default erase sector size of the nor flash has been switched from 4k to 64k. This may cause the configuration not be preserved across upgrades. To avoid this issue, change the default BLOCKSIZE to 64k. Signed-off-by: Shiji Yang <yangshiji66@qq.com>
These same codes are repeated for many devices now, it's better to move them to shared definition. This commit also add the missing KERNEL_SIZE of the ZyXEL NR7101 and ZyXEL LTE3301-PLUS. Signed-off-by: Shiji Yang <yangshiji66@qq.com>
DEVICE_VENDOR := Airlink | ||
DEVICE_MODEL := AR670W | ||
IMAGE_SIZE := 3840k | ||
KERNEL := $(KERNEL_DTB) | pad-to $$(BLOCKSIZE) | ||
KERNEL := $(KERNEL_DTB) | pad-to $$$$(BLOCKSIZE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hauke Sorry I made a mistake here. I didn't notice this error because my local build and ci automatically excluded this device. However, it will surely break the buildbot build.
ref: https://buildbot.staging.openwrt.org/images/#/builders/12/builds/4
I have sent a fix patch to the mailing list and cc to you.
BTW, I suggest marking the rt288x sub-target as source only. Because the only supported device Belkin F5D8235 has only 32MiB RAM, I don't think it can run the 5.15 kernel.
In the kernel 5.15, the default flash sector erase size of the mt7620 sub-target has been switched to 64k. This may cause configuration loss after upgrading the system. This PR solves the potential issue and enables variable size erasure for all sub-target. The last commit is a small cleanup.
Closes: #8715