Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipq40xx: re-add label MAC address for FritzBox 4040 #13240

Merged
merged 1 commit into from Aug 27, 2023

Conversation

fblaese
Copy link
Contributor

@fblaese fblaese commented Aug 7, 2023

The MAC address of the GMAC is contained inside the CWMP-Account number on the label.

The label MAC address alias was defined previously, but it has been removed with the switch to IPQESS / DSA.

Restore the label MAC address alias.

Fixes: 27b441c ("ipq40xx: drop ESSEDMA + AR40xx DTS nodes")

@github-actions github-actions bot added kernel pull request/issue with Linux kernel related changes target/ipq40xx pull request/issue for ipq40xx target labels Aug 7, 2023
@fblaese
Copy link
Contributor Author

fblaese commented Aug 7, 2023

The label-mac-device alias has been removed for other devices as well.

I am not sure if it is safe to assume that the MAC address of the IPQESS gmac is identical to the ESSEDMA gmac0 (this is the case for the FritzBox 4040). I only have a FritzBox 4040 for testing purposes and I have not checked the source code of both drivers.

@hauke
Copy link
Member

hauke commented Aug 26, 2023

Hi @robimarko Could you please have a look at this pull request.

@robimarko
Copy link
Contributor

@fblaese How are the MAC-s being set?
Since I do not see any userspace code or NVMEM cells, I suppose U-Boot is populating it via the ethernet0 alias.
If it's being set via the ethernet0 alias then the old gmac0 will match gmac here.

Was this runtime tested to produce the MAC matching the label(It looks like it should)

@fblaese
Copy link
Contributor Author

fblaese commented Aug 26, 2023

That is a good question. I haven't looked into this, but the mac address is indeed correct, so I assume it is set up by uboot if the driver does not do it.

This change is run-tested for the FritzBox 4040.

If it is safe to assume that the old gmac0 is equivalent to gmac in this regard, the mac-label-devices should probably be restored for all devices which previously had it.

@robimarko
Copy link
Contributor

That is a safe assumption in most cases but not always.
For the PR:
Reviewed-by: Robert Marko <robimarko@gmail.com>

The MAC address of the GMAC is contained inside the CWMP-Account
number on the label.

The label MAC address alias was defined previously, but it has been
removed with the switch to IPQESS / DSA.

Restore the label MAC address alias.

Fixes: 27b441c ("ipq40xx: drop ESSEDMA + AR40xx DTS nodes")
Signed-off-by: Fabian Bläse <fabian@blaese.de>
Reviewed-by: Robert Marko <robimarko@gmail.com>
@openwrt-bot openwrt-bot merged commit b22d382 into openwrt:main Aug 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel pull request/issue with Linux kernel related changes target/ipq40xx pull request/issue for ipq40xx target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants